[GitHub] [incubator-brpc] x2c3z4 commented on a change in pull request #1667: Add two cmake option for build

[GitBox <gi...@apache.org>]

x2c3z4 commented on a change in pull request #1667:
URL: https://github.com/apache/incubator-brpc/pull/1667#discussion_r790419080



##########
File path: CMakeLists.txt
##########
@@ -25,6 +25,8 @@ option(WITH_DEBUG_SYMBOLS "With debug symbols" ON)
 option(WITH_THRIFT "With thrift framed protocol supported" OFF)
 option(BUILD_UNIT_TESTS "Whether to build unit tests" OFF)
 option(DOWNLOAD_GTEST "Download and build a fresh copy of googletest. Requires Internet access." ON)
+option(BUILD_TOOLS "Whether to build tools" ON)
+option(WITH_SHARED_LIB "With dynamic lib" ON)

Review comment:
       > Hi @x2c3z4 , Thanks for your contribution, could you please explain the reason for adding WITH_SHARED_LIB, thanks!
   
   I want to static link the brpc to my project, and my project has also static linked with leveldb/gflags/glog, so if I link the brpc shared lib, there are some errors that I should handle, so add a switch to control the shared lib is a good option.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org