You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "n0r0shi (via GitHub)" <gi...@apache.org> on 2026/02/25 03:37:10 UTC
[PR] feat: support factorial, pmod, and rint expressions [datafusion-comet]
n0r0shi opened a new pull request, #3586:
URL: https://github.com/apache/datafusion-comet/pull/3586
## Summary
- Wire three math functions from the `datafusion-spark` crate (`SparkFactorial`, `SparkPmod`, `SparkRint`) to Comet
- Register in `jni_api.rs` and add serde mappings via `CometScalarFunction` in `QueryPlanSerde.scala`
## Test plan
- [x] New tests in `CometMathExpressionSuite` (factorial, pmod, rint) — all pass
- [x] Spotless formatting check passes
- [x] Rust native build passes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: support factorial, pmod, and rint expressions [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #3586:
URL: https://github.com/apache/datafusion-comet/pull/3586#issuecomment-4684135144
Thanks @n0r0shi but these expressions are now supported by the codegen dispatch approach, so closing this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: support factorial, pmod, and rint expressions [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #3586:
URL: https://github.com/apache/datafusion-comet/pull/3586#issuecomment-4382841199
@n0r0shi I am moving this to draft. Feel free to mark as ready for review when CI failures are addressed. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: support factorial, pmod, and rint expressions [datafusion-comet]
Posted by "coderfender (via GitHub)" <gi...@apache.org>.
coderfender commented on PR #3586:
URL: https://github.com/apache/datafusion-comet/pull/3586#issuecomment-4043950854
Issue : https://github.com/apache/datafusion-comet/pull/3586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: support factorial, pmod, and rint expressions [datafusion-comet]
Posted by "coderfender (via GitHub)" <gi...@apache.org>.
coderfender commented on PR #3586:
URL: https://github.com/apache/datafusion-comet/pull/3586#issuecomment-4043694493
I don't think we can use `pdod` function as is from DF and might want to implement comet native / spark specific functionality
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: support factorial, pmod, and rint expressions [datafusion-comet]
Posted by "coderfender (via GitHub)" <gi...@apache.org>.
coderfender commented on PR #3586:
URL: https://github.com/apache/datafusion-comet/pull/3586#issuecomment-4040308784
```
sql-file: expressions/math/pmod.sql [parquet.enable.dictionary=false] *** FAILED *** (149 milliseconds)
org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 1871.0 failed 1 times, most recent failure: Lost task 0.0 in stage 1871.0 (TID 7089) (localhost executor driver): org.apache.comet.CometNativeException: Divide by zero error
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: support factorial, pmod, and rint expressions [datafusion-comet]
Posted by "n0r0shi (via GitHub)" <gi...@apache.org>.
n0r0shi commented on PR #3586:
URL: https://github.com/apache/datafusion-comet/pull/3586#issuecomment-4001564773
@andygrove Thanks for the review! I've addressed your feedback. Also merged with latest main to resolve conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: support factorial, pmod, and rint expressions [datafusion-comet]
Posted by "coderfender (via GitHub)" <gi...@apache.org>.
coderfender commented on PR #3586:
URL: https://github.com/apache/datafusion-comet/pull/3586#issuecomment-4047978199
@n0r0shi , perhaps you could refactor your code to drop support for `pmod` support so that we can merge this PR and and then come back once comet is upgraded to DF53 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: support factorial, pmod, and rint expressions [datafusion-comet]
Posted by "coderfender (via GitHub)" <gi...@apache.org>.
coderfender commented on PR #3586:
URL: https://github.com/apache/datafusion-comet/pull/3586#issuecomment-4040305572
@andygrove , @n0r0shi there are test failures here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: support factorial, pmod, and rint expressions [datafusion-comet]
Posted by "n0r0shi (via GitHub)" <gi...@apache.org>.
n0r0shi commented on PR #3586:
URL: https://github.com/apache/datafusion-comet/pull/3586#issuecomment-4048362460
@coderfender Sure, thank you for the advice. I have other PRs that also depend on DF 53, so I can drop pmod and update this PR for now. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: support factorial, pmod, and rint expressions [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #3586:
URL: https://github.com/apache/datafusion-comet/pull/3586#issuecomment-4055042882
CI failure:
```
- sql-file: expressions/math/pmod.sql [parquet.enable.dictionary=false] *** FAILED *** (107 milliseconds)
org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 1872.0 failed 1 times, most recent failure: Lost task 0.0 in stage 1872.0 (TID 7094) (localhost executor driver): org.apache.comet.CometNativeException: Divide by zero error
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: support factorial, pmod, and rint expressions [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove closed pull request #3586: feat: support factorial, pmod, and rint expressions
URL: https://github.com/apache/datafusion-comet/pull/3586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org