[jira] [Commented] (KAFKA-3571) Traits for utilities like ConsumerGroupCommand

["Ismael Juma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244359#comment-15244359 ] 

Ismael Juma commented on KAFKA-3571:
------------------------------------

I think KIP-4 may be a better way to do this.

> Traits for utilities like ConsumerGroupCommand
> ----------------------------------------------
>
>                 Key: KAFKA-3571
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3571
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>    Affects Versions: 0.9.0.1
>            Reporter: Greg Zoller
>            Priority: Minor
>
> I notice that several utilities like ConsumerGroupCommand are implemented (hard-wired really) to be command-line utilities.  It'd be really handy for testing if these were broken out as Scala traits (that don't call println) with the concrete classes or objects being the command-line utility.
> As a trait I could create a thin wrapper class passing the same array of arguments, and instead of producing screen output the trait could produce result classes.  
> The command-line utilities (your concrete classes implementing the traits) could format screen output from the result classes.
> Why do this?  It'd be a really nice way for test code to query things like offsets and such after a test run.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)