You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2024/11/13 01:29:09 UTC

[Impala-ASF-CR] IMPALA-13543: single node perf run.py must accept tpcds partitioned

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22061


Change subject: IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned
......................................................................

IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned

tpcds_partitioned dataset is a fully-partitioned version of tpcds
dataset (the latter only partition store_sales table). It does not have
the default text format database like tpcds dataset. Instead, it relies
on pre-existence of text format tpcds database, which then INSERT
OVERWRITE INTO tpcds_partitioned database equivalent. It does not have
its own queries set, but instead symlinked to share
testdata/workloads/tpcds/queries. It also have slightly different schema
from tpcds dataset, namely column "c_last_review_date" in tpcds dataset
is "c_last_review_date_sk" in tpcds_partitioned (TPC-DS v2.11.0, see
related commit in impala-tpcds-kit). These reasons make
tpcds_partitioned ineligible for perf-AB-test (single_node_perf_run.py)

This patch update single_node_perf_run.py and related scripts to make
tpcds_partitioned eligible for benchmark dataset. It adds an initial
steps to load the text database from tpcds dataset with selected scale
before running the load script for tpcds_partitioned dataset. Compute
stats step also limited to run one at a time to not overadmit the
cluster with concurrent compute stats queries.

Testing
- Run perf-AB-test-ub2004 with this commit included and confirm
  benchmark works with tpcds_partitioned dataset.

Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
---
M bin/single_node_perf_run.py
M testdata/bin/generate-schema-statements.py
M testdata/datasets/tpcds_partitioned/tpcds_partitioned_schema_template.sql
M tests/util/test_file_parser.py
4 files changed, 118 insertions(+), 77 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/22061/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Gerrit-Change-Number: 22061
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13543: single node perf run.py must accept tpcds partitioned

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.

Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22061 )

Change subject: IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Gerrit-Change-Number: 22061
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Nov 2024 14:41:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13543: single node perf run.py must accept tpcds partitioned

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.

Hello Quanlong Huang, Joe McDonnell, Michael Smith, Csaba Ringhofer, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/22061

to look at the new patch set (#3).

Change subject: IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned
......................................................................

IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned

tpcds_partitioned dataset is a fully-partitioned version of tpcds
dataset (the latter only partition store_sales table). It does not have
the default text format database like tpcds dataset. Instead, it relies
on pre-existence of text format tpcds database, which then INSERT
OVERWRITE INTO tpcds_partitioned database equivalent. It does not have
its own queries set, but instead symlinked to share
testdata/workloads/tpcds/queries. It also have slightly different schema
from tpcds dataset, namely column "c_last_review_date" in tpcds dataset
is "c_last_review_date_sk" in tpcds_partitioned (TPC-DS v2.11.0, section
2.4.7). These reasons make tpcds_partitioned ineligible for
perf-AB-test (single_node_perf_run.py).

This patch update single_node_perf_run.py and related scripts to make
tpcds_partitioned eligible for benchmark dataset. It adds an initial
steps to load the text database from tpcds dataset with selected scale
before running the load script for tpcds_partitioned dataset. Compute
stats step also limited to run one at a time to not overadmit the
cluster with concurrent compute stats queries.

Created helper function build_replacement_params() inside
generate-schema-statements.py for common function.

Testing
- Run perf-AB-test-ub2004 with this commit included and confirm
benchmark works with tpcds_partitioned dataset.
- Run normal data loading. Pass FE tests, and
query_test/test_tpcds_queries.py.

Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
---
M bin/single_node_perf_run.py
M testdata/bin/generate-schema-statements.py
M testdata/datasets/tpcds_partitioned/tpcds_partitioned_schema_template.sql
M tests/util/test_file_parser.py
4 files changed, 184 insertions(+), 111 deletions(-)

git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/22061/3
--
To view, visit http://gerrit.cloudera.org:8080/22061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Gerrit-Change-Number: 22061
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13543: single node perf run.py must accept tpcds partitioned

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22061 )

Change subject: IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11145/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Gerrit-Change-Number: 22061
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2024 01:45:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13543: single node perf run.py must accept tpcds partitioned

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22061 )

Change subject: IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Gerrit-Change-Number: 22061
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2024 01:45:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13543: single node perf run.py must accept tpcds partitioned

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22061 )

Change subject: IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22061/2/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:

http://gerrit.cloudera.org:8080/#/c/22061/2/testdata/bin/generate-schema-statements.py@623
PS2, Line 623: , data_set="",
             :     scale_factor=""
not used?



-- 
To view, visit http://gerrit.cloudera.org:8080/22061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Gerrit-Change-Number: 22061
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Nov 2024 07:19:26 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13543: single node perf run.py must accept tpcds partitioned

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22061 )

Change subject: IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17501/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Gerrit-Change-Number: 22061
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Nov 2024 23:47:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13543: single node perf run.py must accept tpcds partitioned

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22061 )

Change subject: IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/17445/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Gerrit-Change-Number: 22061
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Nov 2024 01:56:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13543: single node perf run.py must accept tpcds partitioned

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.

Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22061 )

Change subject: IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22061/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22061/1//COMMIT_MSG@29
PS1, Line 29: - Run perf-AB-test-ub2004 with this commit included and confirm
            :   benchmark works with tpcds_partitioned dataset.
Latest run I did is https://jenkins.impala.io/job/perf-AB-test-ub2004/168/



-- 
To view, visit http://gerrit.cloudera.org:8080/22061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Gerrit-Change-Number: 22061
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Nov 2024 01:31:38 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13543: single node perf run.py must accept tpcds partitioned

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.

Hello Joe McDonnell, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22061

to look at the new patch set (#2).

Change subject: IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned
......................................................................

IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned

tpcds_partitioned dataset is a fully-partitioned version of tpcds
dataset (the latter only partition store_sales table). It does not have
the default text format database like tpcds dataset. Instead, it relies
on pre-existence of text format tpcds database, which then INSERT
OVERWRITE INTO tpcds_partitioned database equivalent. It does not have
its own queries set, but instead symlinked to share
testdata/workloads/tpcds/queries. It also have slightly different schema
from tpcds dataset, namely column "c_last_review_date" in tpcds dataset
is "c_last_review_date_sk" in tpcds_partitioned (TPC-DS v2.11.0, section
2.4.7). These reasons make tpcds_partitioned ineligible for
perf-AB-test (single_node_perf_run.py).

This patch update single_node_perf_run.py and related scripts to make
tpcds_partitioned eligible for benchmark dataset. It adds an initial
steps to load the text database from tpcds dataset with selected scale
before running the load script for tpcds_partitioned dataset. Compute
stats step also limited to run one at a time to not overadmit the
cluster with concurrent compute stats queries.

Testing
- Run perf-AB-test-ub2004 with this commit included and confirm
  benchmark works with tpcds_partitioned dataset.
- Run normal data loading. Pass FE tests, and
  query_test/test_tpcds_queries.py.

Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
---
M bin/single_node_perf_run.py
M testdata/bin/generate-schema-statements.py
M testdata/datasets/tpcds_partitioned/tpcds_partitioned_schema_template.sql
M tests/util/test_file_parser.py
4 files changed, 118 insertions(+), 77 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/22061/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Gerrit-Change-Number: 22061
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13543: single node perf run.py must accept tpcds partitioned

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.

Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22061 )

Change subject: IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22061/2/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:

http://gerrit.cloudera.org:8080/#/c/22061/2/testdata/bin/generate-schema-statements.py@623
PS2, Line 623: 
             :   hbase_insert = SE
> not used?
I decide to drop 'data_set' entirely and create build_replacement_params() helper function for consistency.



-- 
To view, visit http://gerrit.cloudera.org:8080/22061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Gerrit-Change-Number: 22061
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Nov 2024 23:20:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13543: single node perf run.py must accept tpcds partitioned

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22061 )

Change subject: IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

LGTM. Carry Csaba's +1.

http://gerrit.cloudera.org:8080/#/c/22061/2/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:

http://gerrit.cloudera.org:8080/#/c/22061/2/testdata/bin/generate-schema-statements.py@623
PS2, Line 623: 
             :   hbase_insert = SE
> I decide to drop 'data_set' entirely and create build_replacement_params() 
Ack. Thanks for doing the cleanup!



-- 
To view, visit http://gerrit.cloudera.org:8080/22061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Gerrit-Change-Number: 22061
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2024 01:14:39 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13543: single node perf run.py must accept tpcds partitioned

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22061 )

Change subject: IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned
......................................................................

IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned

Created helper function build_replacement_params() inside
generate-schema-statements.py for common function.

Testing
- Run perf-AB-test-ub2004 with this commit included and confirm
benchmark works with tpcds_partitioned dataset.
- Run normal data loading. Pass FE tests, and
query_test/test_tpcds_queries.py.

Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Reviewed-on: http://gerrit.cloudera.org:8080/22061
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/single_node_perf_run.py
M testdata/bin/generate-schema-statements.py
M testdata/datasets/tpcds_partitioned/tpcds_partitioned_schema_template.sql
M tests/util/test_file_parser.py
4 files changed, 184 insertions(+), 111 deletions(-)

Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/22061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Gerrit-Change-Number: 22061
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13543: single node perf run.py must accept tpcds partitioned

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22061 )

Change subject: IMPALA-13543: single_node_perf_run.py must accept tpcds_partitioned
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6f435705dcf873696ffd151052ebeab35d9898
Gerrit-Change-Number: 22061
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2024 07:11:41 +0000
Gerrit-HasComments: No