[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5103: arch/risc-v: Refine riscv_fpu.S

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #5103:
URL: https://github.com/apache/incubator-nuttx/pull/5103#discussion_r776161182



##########
File path: arch/risc-v/src/common/riscv_fpu.S
##########
@@ -95,7 +108,7 @@ up_fpuconfig:
  *   floating point registers.
  *
  * C Function Prototype:
- *   void riscv_savefpu(uint64_t *regs);
+ *   void riscv_savefpu(uintptr_t *regs);

Review comment:
       should we change the prototype in up_internal.h:
   ```
   #ifdef CONFIG_ARCH_FPU
   #ifdef CONFIG_ARCH_RV64
   void riscv_savefpu(uint64_t *regs);
   void riscv_restorefpu(const uint64_t *regs);
   #else /* !CONFIG_ARCH_RV64 */
   void riscv_savefpu(uint32_t *regs);
   void riscv_restorefpu(const uint32_t *regs);
   #endif /* CONFIG_ARCH_RV64 */
   #else
   #  define riscv_savefpu(regs)
   #  define riscv_restorefpu(regs)
   #endif
   ```
   to:
   #ifdef CONFIG_ARCH_FPU
   void riscv_savefpu(uintptr_t *regs);
   void riscv_restorefpu(const uintptr_t *regs);
   #else
   #  define riscv_savefpu(regs)
   #  define riscv_restorefpu(regs)
   #endif
   

##########
File path: arch/risc-v/src/common/riscv_fpu.S
##########
@@ -23,7 +23,12 @@
  ************************************************************************************/
 
 #include <nuttx/config.h>
+
+#ifdef CONFIG_ARCH_RV32
+#include <arch/rv32im/irq.h>

Review comment:
       let's merge irq.h in the future patch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org