You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by dolphy17 <gi...@git.apache.org> on 2017/10/11 15:08:22 UTC
[GitHub] zookeeper pull request #400: ZOOKEEPER-1703: Added instructions on how to ru...
GitHub user dolphy17 opened a pull request:
https://github.com/apache/zookeeper/pull/400
ZOOKEEPER-1703: Added instructions on how to run the example code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dolphy17/zookeeper master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/400.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #400
----
commit 45ff981686231f05a7c87c677e76b6546633cd33
Author: Andor Molnar <an...@cloudera.com>
Date: 2017-10-11T15:06:13Z
ZOOKEEPER-1703: Added instructions on how to run the example code
----
---
[GitHub] zookeeper issue #400: ZOOKEEPER-1703: Added instructions on how to run the e...
Posted by afine <gi...@git.apache.org>.
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/400
@dolphy17 i went ahead and resubmitted the build.
---
[GitHub] zookeeper pull request #400: ZOOKEEPER-1703: Added instructions on how to ru...
Posted by dolphy17 <gi...@git.apache.org>.
Github user dolphy17 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/400#discussion_r144193534
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperTutorial.xml ---
@@ -361,7 +361,40 @@ from each one.</para>
</programlisting>
</section>
-<section id="sc_sourceListing"><title>Complete Source Listing</title>
+
+<section>
+<title>Complete example</title>
+<para>
+In the following section you can find a complete command line application to demonstrate the above mentioned
+recipes. Use the following command to run it.
+</para>
+<programlisting>
+export CLASSPATH=".:$ZOOKEEPER_HOME/*:$ZOOKEEPER_HOME/lib/*:$ZOOKEEPER_HOME/conf"
--- End diff --
Sure, makes sense.
I've stolen this from the Hadoop Definitive Guide.
Will take a look at the other.
---
[GitHub] zookeeper pull request #400: ZOOKEEPER-1703: Added instructions on how to ru...
Posted by afine <gi...@git.apache.org>.
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/400#discussion_r144192181
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperTutorial.xml ---
@@ -361,7 +361,40 @@ from each one.</para>
</programlisting>
</section>
-<section id="sc_sourceListing"><title>Complete Source Listing</title>
+
+<section>
+<title>Complete example</title>
+<para>
+In the following section you can find a complete command line application to demonstrate the above mentioned
+recipes. Use the following command to run it.
+</para>
+<programlisting>
+export CLASSPATH=".:$ZOOKEEPER_HOME/*:$ZOOKEEPER_HOME/lib/*:$ZOOKEEPER_HOME/conf"
--- End diff --
we use different instructions for defining the classpath in the Administrators guide. It would be great to be consistent here. Also, is conf needed in the classpath?
---
[GitHub] zookeeper issue #400: ZOOKEEPER-1703: Added instructions on how to run the e...
Posted by phunt <gi...@git.apache.org>.
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/400
Latest one is green, not sure why PR is not updated:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1106/
---
[GitHub] zookeeper issue #400: ZOOKEEPER-1703: Added instructions on how to run the e...
Posted by dolphy17 <gi...@git.apache.org>.
Github user dolphy17 commented on the issue:
https://github.com/apache/zookeeper/pull/400
@afine I've updated the PR with new classpath setting.
---
[GitHub] zookeeper issue #400: ZOOKEEPER-1703: Added instructions on how to run the e...
Posted by dolphy17 <gi...@git.apache.org>.
Github user dolphy17 commented on the issue:
https://github.com/apache/zookeeper/pull/400
Tests are failing due to OutOfMemoryError.
How can I trigger another build?
---
[GitHub] zookeeper pull request #400: ZOOKEEPER-1703: Added instructions on how to ru...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/400
---
[GitHub] zookeeper issue #400: ZOOKEEPER-1703: Added instructions on how to run the e...
Posted by dolphy17 <gi...@git.apache.org>.
Github user dolphy17 commented on the issue:
https://github.com/apache/zookeeper/pull/400
Build is failing again, but I can't see the reason why.
---
[GitHub] zookeeper issue #400: ZOOKEEPER-1703: Added instructions on how to run the e...
Posted by dolphy17 <gi...@git.apache.org>.
Github user dolphy17 commented on the issue:
https://github.com/apache/zookeeper/pull/400
thanks @afine
Some hint on the code changes: consumer code wasn't able to delete the node, because it concatenated the string 'element' with an integer which resulted in something like '/app1/element1', but the actual node was '/app1/element00000001'. This is the standard behaviour of creating sequential nodes, ZK adds a couple of leading zeros.
To fix this, consumer now saves the name of the node together with its number to delete it properly.
---