You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/03/06 14:58:16 UTC

[GitHub] [nifi] freddytuxworth opened a new pull request #3354: NIFI-6106 Add tests for commons utilities & fix FormatUtils bug

freddytuxworth opened a new pull request #3354: NIFI-6106 Add tests for commons utilities & fix FormatUtils bug
URL: https://github.com/apache/nifi/pull/3354
 
 
   I analyzed this project and noticed some methods lacking tests in these two utilities classes. I've written some tests using [Diffblue](https://www.diffblue.com/) [Cover](https://www.diffblue.com/datasheet) which should hopefully help you to detect any regressions caused by future code changes. 
   
   I also corrected a small bug in `FormatUtils` which caused the `formatNanos` method to incorrectly format multiples of 1000000 or 1000000000 to `"0 nanos"`.
   
   Please let me know if there are any other areas of your project which you would like tests written for, I would be more than happy to help.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services