You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "dweiss (via GitHub)" <gi...@apache.org> on 2024/08/29 11:48:26 UTC

[I] Upgrade to gradle 8.10 [lucene]

dweiss opened a new issue, #13698:
URL: https://github.com/apache/lucene/issues/13698

   ### Description
   
   As in the title.
   
   ### Version and environment details
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] Upgrade to gradle 8.10 [lucene]

Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on issue #13698:
URL: https://github.com/apache/lucene/issues/13698#issuecomment-2318606215

   Discovered google java format regression (tidy difference): https://github.com/google/google-java-format/issues/1153


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] Upgrade to gradle 8.10 [lucene]

Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on issue #13698:
URL: https://github.com/apache/lucene/issues/13698#issuecomment-2318015631

   So... it's hell again. I can't explain it but objects stored in project.ext during configuration phase seem to be dynamically changing. For example, we store testOptions as an array and append various options to this array. But after the upgrade, the array object seems to be dynamically restored for some tasks (and is incomplete). I think it has to do with "configuration cache" and how gradle actively tries to detect changes to certain objects [1]. 
   
   The problem is that we actively utilize almost everything they now forbid or deprecated... I understand the wish to not execute any code during configuration but at the same time the "supported" way of doing certain things is just plain ugly, more verbose and less intuitive... Eh. 
   
   I'm not sure how to proceed here yet. Seems like making it work will require a lot of adaptation to those new conventions and build code rewriting.
   
   [1] https://docs.gradle.org/current/userguide/configuration_cache.html#config_cache:troubleshooting
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] Upgrade to gradle 8.10 [lucene]

Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on issue #13698:
URL: https://github.com/apache/lucene/issues/13698#issuecomment-2318115591

   Ok, so one thing about the objects changing is that 'ext' now resolves to a different property (a property on a different object) depending on the context. I think I fixed this one. I'm not sure I have faith in the direction where gradle is heading. Seems like a lot of boilerplate for something that used to be simple and just worked. I'll see if I can get 8.10 to work but in general, a cleanup/ rewrite of many things will be needed or a switch to a different built system. Maybe we can ping Linus and he'll write one in a week. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] Upgrade to gradle 8.10 [lucene]

Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on issue #13698:
URL: https://github.com/apache/lucene/issues/13698#issuecomment-2318946943

   I filed a PR which passes CI tests. I have not been testing locally though - it'd be good if you tried if everything works as expected before we merge this in, @ChrisHegarty . 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] Upgrade to gradle 8.10 [lucene]

Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss closed issue #13698: Upgrade to gradle 8.10
URL: https://github.com/apache/lucene/issues/13698


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org