You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@abdera.apache.org by "Abhinav Khandelwal (JIRA)" <ji...@apache.org> on 2008/01/31 05:23:34 UTC
[jira] Created: (ABDERA-97) Change SampleAdapter to take Feed
Configuration rather then Properties and feedId
Change SampleAdapter to take Feed Configuration rather then Properties and feedId
---------------------------------------------------------------------------------
Key: ABDERA-97
URL: https://issues.apache.org/jira/browse/ABDERA-97
Project: Abdera
Issue Type: Improvement
Affects Versions: 0.4.0
Reporter: Abhinav Khandelwal
Fix For: 0.4.0
Attachments: abdera_patch.zip
Newly added SampleAdapter forces the users to provide Poperties and feedId to configure the Adapter.
Using Properties is may not be ideal for a lot of the environments (where abdera might be used) and adapters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ABDERA-97) Change SampleAdapter to take Feed
Configuration rather then Properties and feedId
Posted by "James M Snell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566267#action_12566267 ]
James M Snell commented on ABDERA-97:
-------------------------------------
The hang is being caused by the ClientResponse object not being released. Make sure you always release the ClientResponse when you're doing using it
> Change SampleAdapter to take Feed Configuration rather then Properties and feedId
> ---------------------------------------------------------------------------------
>
> Key: ABDERA-97
> URL: https://issues.apache.org/jira/browse/ABDERA-97
> Project: Abdera
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Abhinav Khandelwal
> Fix For: 0.4.0
>
> Attachments: abdera.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Newly added SampleAdapter forces the users to provide Poperties and feedId to configure the Adapter.
> Using Properties is may not be ideal for a lot of the environments (where abdera might be used) and adapters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ABDERA-97) Change SampleAdapter to take Feed
Configuration rather then Properties and feedId
Posted by "Abhinav Khandelwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abhinav Khandelwal updated ABDERA-97:
-------------------------------------
Attachment: (was: abdera.patch)
> Change SampleAdapter to take Feed Configuration rather then Properties and feedId
> ---------------------------------------------------------------------------------
>
> Key: ABDERA-97
> URL: https://issues.apache.org/jira/browse/ABDERA-97
> Project: Abdera
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Abhinav Khandelwal
> Fix For: 0.4.0
>
> Attachments: abdera.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Newly added SampleAdapter forces the users to provide Poperties and feedId to configure the Adapter.
> Using Properties is may not be ideal for a lot of the environments (where abdera might be used) and adapters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ABDERA-97) Change SampleAdapter to take Feed
Configuration rather then Properties and feedId
Posted by "James M Snell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566271#action_12566271 ]
James M Snell commented on ABDERA-97:
-------------------------------------
Hmm.. this is still causing some build errors (see BasicWorkspace). Also, I believe CollectionAdapterManager would need to be modified to support this approach. I'll take a look at this a bit later this week to see how to get this in.
> Change SampleAdapter to take Feed Configuration rather then Properties and feedId
> ---------------------------------------------------------------------------------
>
> Key: ABDERA-97
> URL: https://issues.apache.org/jira/browse/ABDERA-97
> Project: Abdera
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Abhinav Khandelwal
> Fix For: 0.4.0
>
> Attachments: abdera.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Newly added SampleAdapter forces the users to provide Poperties and feedId to configure the Adapter.
> Using Properties is may not be ideal for a lot of the environments (where abdera might be used) and adapters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ABDERA-97) Change SampleAdapter to take Feed
Configuration rather then Properties and feedId
Posted by "James M Snell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566213#action_12566213 ]
James M Snell commented on ABDERA-97:
-------------------------------------
In general, I like this approach, however, the patch does not change all the pieces necessary for this to work and i simply do not have the time right now to flush out all the details myself. I might be able to get to it later this week. However, if you'd like to take a whack at updating the patch to resolve all the issues, I'd likely be able to get it in faster.
> Change SampleAdapter to take Feed Configuration rather then Properties and feedId
> ---------------------------------------------------------------------------------
>
> Key: ABDERA-97
> URL: https://issues.apache.org/jira/browse/ABDERA-97
> Project: Abdera
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Abhinav Khandelwal
> Fix For: 0.4.0
>
> Attachments: abdera.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Newly added SampleAdapter forces the users to provide Poperties and feedId to configure the Adapter.
> Using Properties is may not be ideal for a lot of the environments (where abdera might be used) and adapters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ABDERA-97) Change SampleAdapter to take Feed
Configuration rather then Properties and feedId
Posted by "Abhinav Khandelwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abhinav Khandelwal updated ABDERA-97:
-------------------------------------
Attachment: abdera.patch
I think this patch should work.
Compiles .. all tests pass.
Yesterday's break was due to not cleaning the build before compiling and running the tests.
> Change SampleAdapter to take Feed Configuration rather then Properties and feedId
> ---------------------------------------------------------------------------------
>
> Key: ABDERA-97
> URL: https://issues.apache.org/jira/browse/ABDERA-97
> Project: Abdera
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Abhinav Khandelwal
> Fix For: 0.4.0
>
> Attachments: abdera.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Newly added SampleAdapter forces the users to provide Poperties and feedId to configure the Adapter.
> Using Properties is may not be ideal for a lot of the environments (where abdera might be used) and adapters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ABDERA-97) Change SampleAdapter to
take Feed Configuration rather then Properties and feedId
Posted by "Abhinav Khandelwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566636#action_12566636 ]
abhinavk edited comment on ABDERA-97 at 2/7/08 7:28 AM:
------------------------------------------------------------------
I think this patch should work.
Compiles .. all tests pass.
Yesterday's break was due to not cleaning the build before compiling and running the tests.
Can you please have a look at this.
was (Author: abhinavk):
I think this patch should work.
Compiles .. all tests pass.
Yesterday's break was due to not cleaning the build before compiling and running the tests.
> Change SampleAdapter to take Feed Configuration rather then Properties and feedId
> ---------------------------------------------------------------------------------
>
> Key: ABDERA-97
> URL: https://issues.apache.org/jira/browse/ABDERA-97
> Project: Abdera
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Abhinav Khandelwal
> Fix For: 0.4.0
>
> Attachments: abdera.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Newly added SampleAdapter forces the users to provide Poperties and feedId to configure the Adapter.
> Using Properties is may not be ideal for a lot of the environments (where abdera might be used) and adapters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ABDERA-97) Change SampleAdapter to take Feed
Configuration rather then Properties and feedId
Posted by "Abhinav Khandelwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abhinav Khandelwal updated ABDERA-97:
-------------------------------------
Attachment: (was: abdera.patch)
> Change SampleAdapter to take Feed Configuration rather then Properties and feedId
> ---------------------------------------------------------------------------------
>
> Key: ABDERA-97
> URL: https://issues.apache.org/jira/browse/ABDERA-97
> Project: Abdera
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Abhinav Khandelwal
> Fix For: 0.4.0
>
> Attachments: abdera.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Newly added SampleAdapter forces the users to provide Poperties and feedId to configure the Adapter.
> Using Properties is may not be ideal for a lot of the environments (where abdera might be used) and adapters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ABDERA-97) Change SampleAdapter to take Feed
Configuration rather then Properties and feedId
Posted by "James M Snell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James M Snell resolved ABDERA-97.
---------------------------------
Resolution: Fixed
A modified version of the patch was checked in. There is a new ManagedProvider/ManagedWorkspace/ManagedCollectionAdapter base implementation that BasicProvider/BasicAdapter extend. This uses the deployment and config mechanism provided by google. I implemented it this way because not all Provider implementations are going to need to utilize this configuration mechanism. It would be wrong to force them to deal with it.
> Change SampleAdapter to take Feed Configuration rather then Properties and feedId
> ---------------------------------------------------------------------------------
>
> Key: ABDERA-97
> URL: https://issues.apache.org/jira/browse/ABDERA-97
> Project: Abdera
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Abhinav Khandelwal
> Fix For: 0.4.0
>
> Attachments: abdera.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Newly added SampleAdapter forces the users to provide Poperties and feedId to configure the Adapter.
> Using Properties is may not be ideal for a lot of the environments (where abdera might be used) and adapters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ABDERA-97) Change SampleAdapter to take Feed
Configuration rather then Properties and feedId
Posted by "James M Snell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566855#action_12566855 ]
James M Snell commented on ABDERA-97:
-------------------------------------
Ok, thx! I'll review the patch; at first glance I think I see a few things I may change around. I'll see if I can have this resolved by the end of the day friday
> Change SampleAdapter to take Feed Configuration rather then Properties and feedId
> ---------------------------------------------------------------------------------
>
> Key: ABDERA-97
> URL: https://issues.apache.org/jira/browse/ABDERA-97
> Project: Abdera
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Abhinav Khandelwal
> Fix For: 0.4.0
>
> Attachments: abdera.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Newly added SampleAdapter forces the users to provide Poperties and feedId to configure the Adapter.
> Using Properties is may not be ideal for a lot of the environments (where abdera might be used) and adapters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ABDERA-97) Change SampleAdapter to take Feed
Configuration rather then Properties and feedId
Posted by "Abhinav Khandelwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abhinav Khandelwal updated ABDERA-97:
-------------------------------------
Attachment: abdera.patch
> Change SampleAdapter to take Feed Configuration rather then Properties and feedId
> ---------------------------------------------------------------------------------
>
> Key: ABDERA-97
> URL: https://issues.apache.org/jira/browse/ABDERA-97
> Project: Abdera
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Abhinav Khandelwal
> Fix For: 0.4.0
>
> Attachments: abdera.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Newly added SampleAdapter forces the users to provide Poperties and feedId to configure the Adapter.
> Using Properties is may not be ideal for a lot of the environments (where abdera might be used) and adapters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ABDERA-97) Change SampleAdapter to take Feed
Configuration rather then Properties and feedId
Posted by "Abhinav Khandelwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abhinav Khandelwal updated ABDERA-97:
-------------------------------------
Attachment: (was: abdera_patch.zip)
> Change SampleAdapter to take Feed Configuration rather then Properties and feedId
> ---------------------------------------------------------------------------------
>
> Key: ABDERA-97
> URL: https://issues.apache.org/jira/browse/ABDERA-97
> Project: Abdera
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Abhinav Khandelwal
> Fix For: 0.4.0
>
> Attachments: abdera.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Newly added SampleAdapter forces the users to provide Poperties and feedId to configure the Adapter.
> Using Properties is may not be ideal for a lot of the environments (where abdera might be used) and adapters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ABDERA-97) Change SampleAdapter to take Feed
Configuration rather then Properties and feedId
Posted by "Abhinav Khandelwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abhinav Khandelwal updated ABDERA-97:
-------------------------------------
Attachment: abdera.patch
Fixed the issue where the patch was breaking the build. Made changes to fix the Sample adapter in test
Though the server tests are getting stuck (or taking too long) after opening the socket for 4th time. Which I think is not due to this patch.
> Change SampleAdapter to take Feed Configuration rather then Properties and feedId
> ---------------------------------------------------------------------------------
>
> Key: ABDERA-97
> URL: https://issues.apache.org/jira/browse/ABDERA-97
> Project: Abdera
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Abhinav Khandelwal
> Fix For: 0.4.0
>
> Attachments: abdera.patch, abdera.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Newly added SampleAdapter forces the users to provide Poperties and feedId to configure the Adapter.
> Using Properties is may not be ideal for a lot of the environments (where abdera might be used) and adapters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ABDERA-97) Change SampleAdapter to take Feed
Configuration rather then Properties and feedId
Posted by "Abhinav Khandelwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abhinav Khandelwal updated ABDERA-97:
-------------------------------------
Attachment: abdera_patch.zip
Attaching sample changes.
> Change SampleAdapter to take Feed Configuration rather then Properties and feedId
> ---------------------------------------------------------------------------------
>
> Key: ABDERA-97
> URL: https://issues.apache.org/jira/browse/ABDERA-97
> Project: Abdera
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Abhinav Khandelwal
> Fix For: 0.4.0
>
> Attachments: abdera_patch.zip
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Newly added SampleAdapter forces the users to provide Poperties and feedId to configure the Adapter.
> Using Properties is may not be ideal for a lot of the environments (where abdera might be used) and adapters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.