You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2023/03/24 16:04:08 UTC
[shardingsphere] branch master updated: Rename DisabledReadDataSourcesFilter (#24820)
This is an automated email from the ASF dual-hosted git repository.
zhaojinchao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new d810357ef60 Rename DisabledReadDataSourcesFilter (#24820)
d810357ef60 is described below
commit d810357ef60119ff9bf148e9fb9647adfb7c32d7
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sat Mar 25 00:03:59 2023 +0800
Rename DisabledReadDataSourcesFilter (#24820)
---
...SourcesFilter.java => DisabledReadDataSourcesFilter.java} | 4 ++--
...ere.readwritesplitting.route.filter.ReadDataSourcesFilter | 2 +-
...ilterTest.java => DisabledReadDataSourcesFilterTest.java} | 12 ++++++------
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/features/readwrite-splitting/core/src/main/java/org/apache/shardingsphere/readwritesplitting/route/filter/EnabledReadDataSourcesFilter.java b/features/readwrite-splitting/core/src/main/java/org/apache/shardingsphere/readwritesplitting/route/filter/DisabledReadDataSourcesFilter.java
similarity index 93%
rename from features/readwrite-splitting/core/src/main/java/org/apache/shardingsphere/readwritesplitting/route/filter/EnabledReadDataSourcesFilter.java
rename to features/readwrite-splitting/core/src/main/java/org/apache/shardingsphere/readwritesplitting/route/filter/DisabledReadDataSourcesFilter.java
index 4cf9b73490b..e1f18eb558e 100644
--- a/features/readwrite-splitting/core/src/main/java/org/apache/shardingsphere/readwritesplitting/route/filter/EnabledReadDataSourcesFilter.java
+++ b/features/readwrite-splitting/core/src/main/java/org/apache/shardingsphere/readwritesplitting/route/filter/DisabledReadDataSourcesFilter.java
@@ -24,9 +24,9 @@ import java.util.LinkedList;
import java.util.List;
/**
- * Enabled read data sources filter.
+ * Disabled read data sources filter.
*/
-public final class EnabledReadDataSourcesFilter implements ReadDataSourcesFilter {
+public final class DisabledReadDataSourcesFilter implements ReadDataSourcesFilter {
@Override
public List<String> filter(final ReadwriteSplittingDataSourceRule rule, final List<String> toBeFilteredReadDataSources) {
diff --git a/features/readwrite-splitting/core/src/main/resources/META-INF/services/org.apache.shardingsphere.readwritesplitting.route.filter.ReadDataSourcesFilter b/features/readwrite-splitting/core/src/main/resources/META-INF/services/org.apache.shardingsphere.readwritesplitting.route.filter.ReadDataSourcesFilter
index 4021df64128..a441670e920 100644
--- a/features/readwrite-splitting/core/src/main/resources/META-INF/services/org.apache.shardingsphere.readwritesplitting.route.filter.ReadDataSourcesFilter
+++ b/features/readwrite-splitting/core/src/main/resources/META-INF/services/org.apache.shardingsphere.readwritesplitting.route.filter.ReadDataSourcesFilter
@@ -15,4 +15,4 @@
# limitations under the License.
#
-org.apache.shardingsphere.readwritesplitting.route.filter.EnabledReadDataSourcesFilter
+org.apache.shardingsphere.readwritesplitting.route.filter.DisabledReadDataSourcesFilter
diff --git a/features/readwrite-splitting/core/src/test/java/org/apache/shardingsphere/readwritesplitting/route/filter/EnabledReadDataSourcesFilterTest.java b/features/readwrite-splitting/core/src/test/java/org/apache/shardingsphere/readwritesplitting/route/filter/DisabledReadDataSourcesFilterTest.java
similarity index 77%
rename from features/readwrite-splitting/core/src/test/java/org/apache/shardingsphere/readwritesplitting/route/filter/EnabledReadDataSourcesFilterTest.java
rename to features/readwrite-splitting/core/src/test/java/org/apache/shardingsphere/readwritesplitting/route/filter/DisabledReadDataSourcesFilterTest.java
index 457dc5081a8..fb29aecc379 100644
--- a/features/readwrite-splitting/core/src/test/java/org/apache/shardingsphere/readwritesplitting/route/filter/EnabledReadDataSourcesFilterTest.java
+++ b/features/readwrite-splitting/core/src/test/java/org/apache/shardingsphere/readwritesplitting/route/filter/DisabledReadDataSourcesFilterTest.java
@@ -31,7 +31,7 @@ import java.util.Collections;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
-class EnabledReadDataSourcesFilterTest {
+class DisabledReadDataSourcesFilterTest {
private ReadwriteSplittingDataSourceRule rule;
@@ -45,31 +45,31 @@ class EnabledReadDataSourcesFilterTest {
@Test
void assertGetReadDataSourceNamesWithoutDisabledDataSourceNames() {
- assertThat(new EnabledReadDataSourcesFilter().filter(rule, Arrays.asList("read_ds_0", "read_ds_1")), is(Arrays.asList("read_ds_0", "read_ds_1")));
+ assertThat(new DisabledReadDataSourcesFilter().filter(rule, Arrays.asList("read_ds_0", "read_ds_1")), is(Arrays.asList("read_ds_0", "read_ds_1")));
}
@Test
void assertGetReadDataSourceNamesWithDisabledDataSourceNames() {
rule.updateDisabledDataSourceNames("read_ds_0", true);
- assertThat(new EnabledReadDataSourcesFilter().filter(rule, Arrays.asList("read_ds_0", "read_ds_1")), is(Collections.singletonList("read_ds_1")));
+ assertThat(new DisabledReadDataSourcesFilter().filter(rule, Arrays.asList("read_ds_0", "read_ds_1")), is(Collections.singletonList("read_ds_1")));
}
@Test
void assertUpdateDisabledDataSourceNamesForDisabled() {
rule.updateDisabledDataSourceNames("read_ds_0", true);
- assertThat(new EnabledReadDataSourcesFilter().filter(rule, Arrays.asList("read_ds_0", "read_ds_1")), is(Collections.singletonList("read_ds_1")));
+ assertThat(new DisabledReadDataSourcesFilter().filter(rule, Arrays.asList("read_ds_0", "read_ds_1")), is(Collections.singletonList("read_ds_1")));
}
@Test
void assertUpdateDisabledDataSourceNamesForEnabled() {
rule.updateDisabledDataSourceNames("read_ds_0", true);
rule.updateDisabledDataSourceNames("read_ds_0", false);
- assertThat(new EnabledReadDataSourcesFilter().filter(rule, Arrays.asList("read_ds_0", "read_ds_1")), is(Arrays.asList("read_ds_0", "read_ds_1")));
+ assertThat(new DisabledReadDataSourcesFilter().filter(rule, Arrays.asList("read_ds_0", "read_ds_1")), is(Arrays.asList("read_ds_0", "read_ds_1")));
}
@Test
void assertGetEnabledReplicaDataSources() {
rule.updateDisabledDataSourceNames("read_ds_0", true);
- assertThat(new EnabledReadDataSourcesFilter().filter(rule, Arrays.asList("read_ds_0", "read_ds_1")), is(Collections.singletonList("read_ds_1")));
+ assertThat(new DisabledReadDataSourcesFilter().filter(rule, Arrays.asList("read_ds_0", "read_ds_1")), is(Collections.singletonList("read_ds_1")));
}
}