You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "dan-s1 (via GitHub)" <gi...@apache.org> on 2026/08/14 15:02:28 UTC
[PR] NIFI-16202 Removed Mockito warning that appeared when running the nifi build. [nifi]
dan-s1 opened a new pull request, #11545:
URL: https://github.com/apache/nifi/pull/11545
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-16202](https://issues.apache.org/jira/browse/NIFI-16202)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
- Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status
### Pull Request Formatting
- Pull Request based on current revision of the `main` branch
- Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16202 Removed Mockito warning that appeared when running the nifi build. [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 closed pull request #11545: NIFI-16202 Removed Mockito warning that appeared when running the nifi build.
URL: https://github.com/apache/nifi/pull/11545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16202 Removed Mockito warning that appeared when running the nifi build. [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #11545:
URL: https://github.com/apache/nifi/pull/11545#issuecomment-5345520834
I believe it is still there for the `VerifyBuildLocaleTest`, it is just in a different place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16202 Removed Mockito warning that appeared when running the nifi build. [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #11545:
URL: https://github.com/apache/nifi/pull/11545#issuecomment-5296163421
@exceptionfactory Do you know why I may be seeing the following error on the MacOS
```
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.359 s <<< FAILURE! -- in org.apache.nifi.build.VerifyBuildLocaleTest
[ERROR] org.apache.nifi.build.VerifyBuildLocaleTest.testEnvironmentLocaleMatchesSystemProperties -- Time elapsed: 0.197 s <<< FAILURE!
org.opentest4j.AssertionFailedError: system property - CI_LOCALE:[-Duser.language=ja -Duser.country=JP] ACTUAL:[user.language=en] ==> expected: <true> but was: <false>
at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:232)
at org.apache.nifi.build.VerifyBuildLocaleTest.testEnvironmentLocaleMatchesSystemProperties(VerifyBuildLocaleTest.java:52)
```
I do not think it is related to the changes I made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16202 Removed Mockito warning that appeared when running the nifi build. [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #11545:
URL: https://github.com/apache/nifi/pull/11545#issuecomment-5297474987
Where are you referring to? My changes I believe changed an `argline` for the surefire plugin. Does that affect the environment variables set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16202 Removed Mockito warning that appeared when running the nifi build. [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #11545:
URL: https://github.com/apache/nifi/pull/11545#issuecomment-5297353216
> @exceptionfactory Do you know why I may be seeing the following errors on the MacOS
>
> ```
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.359 s <<< FAILURE! -- in org.apache.nifi.build.VerifyBuildLocaleTest
> [ERROR] org.apache.nifi.build.VerifyBuildLocaleTest.testEnvironmentLocaleMatchesSystemProperties -- Time elapsed: 0.197 s <<< FAILURE!
> org.opentest4j.AssertionFailedError: system property - CI_LOCALE:[-Duser.language=ja -Duser.country=JP] ACTUAL:[user.language=en] ==> expected: <true> but was: <false>
> at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:232)
> at org.apache.nifi.build.VerifyBuildLocaleTest.testEnvironmentLocaleMatchesSystemProperties(VerifyBuildLocaleTest.java:52)
> ```
>
> and on the Windows box
>
> ```
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.207 s <<< FAILURE! -- in org.apache.nifi.build.VerifyBuildLocaleTest
> [ERROR] org.apache.nifi.build.VerifyBuildLocaleTest.testEnvironmentLocaleMatchesSystemProperties -- Time elapsed: 0.097 s <<< FAILURE!
> org.opentest4j.AssertionFailedError: system property - CI_LOCALE:[-Duser.language=fr -Duser.country=FR] ACTUAL:[user.language=en] ==> expected: <true> but was: <false>
> at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:232)
> at org.apache.nifi.build.VerifyBuildLocaleTest.testEnvironmentLocaleMatchesSystemProperties(VerifyBuildLocaleTest.java:52)
> ```
>
> ?
>
> I do not think the changes I made should have any bearing on these unit tests. Please advise. Thanks!
That is a smoke test to ensure locale settings are being based as expected. It points to a missing configuration element in the new plugin definitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16202 Removed Mockito warning that appeared when running the nifi build. [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #11545:
URL: https://github.com/apache/nifi/pull/11545#issuecomment-5512764208
Thanks for the work on this @dan-s1.
After additional evaluation, I put together an alternative pull request #11612 that preserves the `argLine` passing from the build workflow using a different strategy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16202 Removed Mockito warning that appeared when running the nifi build. [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #11545:
URL: https://github.com/apache/nifi/pull/11545#issuecomment-5344978253
@exceptionfactory I finally solved this by moving the definition of `NIFI_CI_LOCALE` environment variable in `.github/workflows/build.yml` to the `SUREFIRE_OPTS` environment variable definition. It seems that when no `argLine` is defined in the surefire configuration in the pom.xml, then the environment variables defined in the CI/CD build are passed seamlessly to surefire. But when an `argLine` is defined in the surefire configuration in the pom.xml then somehow (not %100 why this is) those environment variables are not passed. As you can see from the multiple attempts, I tried to obtain the `NIFI_CI_LOCALE` environment variable but to no avail. Finally the only solution I found was to relocate where the definition `NIFI_CI_LOCALE` is made which worked. Please let me know if there is an alternate solution which would be better. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16202 Removed Mockito warning that appeared when running the nifi build. [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #11545:
URL: https://github.com/apache/nifi/pull/11545#issuecomment-5333732374
@exceptionfactory I have tried a lot of different things but I cannot seem to get the unit test `org.apache.nifi.build.VerifyBuildLocaleTest.testEnvironmentLocaleMatchesSystemProperties` to pass. I thought my latest change had the best chance as I injected the environment variable NIFI_CI_LOCALE through MAVEN_OPTS but that also did not work. Can you please give me a hand and enlighten me on what I am missing here? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16202 Removed Mockito warning that appeared when running the nifi build. [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #11545:
URL: https://github.com/apache/nifi/pull/11545#issuecomment-5297437815
Was this caused by my changes? Is there something I need to do? If so what is it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16202 Removed Mockito warning that appeared when running the nifi build. [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #11545:
URL: https://github.com/apache/nifi/pull/11545#issuecomment-5297569205
> Where are you referring to? My changes I believe changed an `argline` for the surefire plugin. Does that affect the environment variables set?
Yes, see the build.yml workflow that provides an external `argLine`, which needs to be passed along to any subsequent configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16202 Removed Mockito warning that appeared when running the nifi build. [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #11545:
URL: https://github.com/apache/nifi/pull/11545#issuecomment-5297457136
> Was this caused by my changes? Is there something I need to do? If so what is it?
Yes, I recommend taking a closer look at the Java arguments to make sure they are being passed as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16202 Removed Mockito warning that appeared when running the nifi build. [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #11545:
URL: https://github.com/apache/nifi/pull/11545#issuecomment-5345415158
@dan-s1 I haven't had the opportunity to evaluate the best solution, but the `NIFI_CI_LOCALE` needs to stay defined as an environment variable where it was in the `build.yml`. This is necessary to enable to `VerifyBuildLocaleTest` methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16202 Removed Mockito warning that appeared when running the nifi build. [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #11545:
URL: https://github.com/apache/nifi/pull/11545#issuecomment-5484077018
@exceptionfactory When you get a chance can you please review this PR? I believe I worked out the issues you had brought up while being able to at least remove the Mockito warning messages from environments other than the CI/CD Mac and Windows builds. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org