You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by elek <gi...@git.apache.org> on 2017/04/28 12:52:48 UTC

[GitHub] zeppelin pull request #2299: [ZEPPELIN-2468] Enable websocket without Origin...

GitHub user elek opened a pull request:

    https://github.com/apache/zeppelin/pull/2299

    [ZEPPELIN-2468] Enable websocket without Origin if allowed.origins is *

    Change-Id: Iaad10a69983036e84b766a22fbc32113b926b60d
    
    ### What is this PR for?
    With ZEPPELIN-2288 we restored the check of the Origin field for websocket requests.
    
    Unfortunately the current implementation will deny the request if the Origin HTTP header is empty, even if the zeppelin.server.allowed.origins is *
    
    This patch enables websocket requests without Origin in the HTTP header if the zeppelin.server.allowed.origins=*. This fixes the work behind a restrictive reverse proxy (or behind Apache Knox)
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2468
    
    ### How should this be tested?
    
    It could be tested with curl as described in ZEPPELIN-2288, but I added additional unit test, so the change has been covered on unit test level.
    
    ### Screenshots (if appropriate)
    N/A
    
    ### Questions:
    * Does the licenses files need update? NO
    * Is there breaking changes for older versions? NO
    * Does this needs documentation? NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/elek/zeppelin ZEPPELIN-2468

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2299.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2299
    
----
commit d95bb41b66b243015576153257cd58fee20366ca
Author: Elek, M�rton <el...@users.noreply.github.com>
Date:   2017-04-28T12:46:10Z

    [ZEPPELIN-2468] Enable websocket without Origin if allowed.origins is *
    
    Change-Id: Iaad10a69983036e84b766a22fbc32113b926b60d

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2299: [ZEPPELIN-2468] Enable websocket without Origin...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2299


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2299: [ZEPPELIN-2468] Enable websocket without Origin if all...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2299
  
    Thank you @elek for the fix. Tested on CentOS works well. LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2299: [ZEPPELIN-2468] Enable websocket without Origin if all...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2299
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2299: [ZEPPELIN-2468] Enable websocket without Origin if all...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2299
  
    Merge to master and branch-0.7 if no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---