You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "absurdfarce (via GitHub)" <gi...@apache.org> on 2024/05/02 06:30:10 UTC

Re: [PR] CASSANDRA-19451: An Option of Latency Sensitive Load Balancing Policy [cassandra-java-driver]

absurdfarce commented on code in PR #1915:
URL: https://github.com/apache/cassandra-java-driver/pull/1915#discussion_r1587128032


##########
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/LatencySensitiveLoadBalancingPolicy.java:
##########
@@ -0,0 +1,275 @@
+/*

Review Comment:
   I still need to give this a more complete review but at a minimum this class needs to go in the [examples directory](https://github.com/apache/cassandra-java-driver/tree/4.x/examples/src/main/java/com/datastax/oss/driver/examples) rather than inline with the default LBP like this.  In 4.x the default LBP is intended to be the primary LBP used in nearly all situations; adding another LBP into the same package will significantly confuse that messaging.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org