You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2022/04/25 01:43:46 UTC
[GitHub] [openmeetings] sebawagner opened a new pull request, #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
sebawagner opened a new pull request, #175:
URL: https://github.com/apache/openmeetings/pull/175
Add tooltip to buttons:
And scroll button get only enabled in case there is more then 1 whiteboard available
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on a diff in pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
solomax commented on code in PR #175:
URL: https://github.com/apache/openmeetings/pull/175#discussion_r857231889
##########
openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application_de.properties.xml:
##########
@@ -981,4 +981,7 @@ Bitte am OM server {3} anmelden und sie unter Admininistration -> Gruppen prüfe
<entry key="wizard.button.finish"><![CDATA[Ende]]></entry>
<entry key="zoom.FULL_FIT"><![CDATA[Vollformat]]></entry>
<entry key="zoom.PAGE_WIDTH"><![CDATA[Seitenbreite]]></entry>
+ <entry key="wb.add.whiteboard"><![CDATA[Add new whiteboard to conference room]]></entry>
Review Comment:
German is missing :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
solomax commented on PR #175:
URL: https://github.com/apache/openmeetings/pull/175#issuecomment-1108042133
@sebawagner new labels are added to PoEditor c22ab0ee3
Please update this PR and merge :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on a diff in pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
solomax commented on code in PR #175:
URL: https://github.com/apache/openmeetings/pull/175#discussion_r858187369
##########
openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application_de.properties.xml:
##########
@@ -981,4 +981,7 @@ Bitte am OM server {3} anmelden und sie unter Admininistration -> Gruppen prüfe
<entry key="wizard.button.finish"><![CDATA[Ende]]></entry>
<entry key="zoom.FULL_FIT"><![CDATA[Vollformat]]></entry>
<entry key="zoom.PAGE_WIDTH"><![CDATA[Seitenbreite]]></entry>
+ <entry key="wb.add.whiteboard"><![CDATA[Add new whiteboard to conference room]]></entry>
Review Comment:
yes, not translated :((
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
sebawagner commented on PR #175:
URL: https://github.com/apache/openmeetings/pull/175#issuecomment-1109030847
Thanks @ali-alhaidar!
Sry do I need to re-import the language files from POEditor into our source code repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] ali-alhaidary commented on pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
ali-alhaidary commented on PR #175:
URL: https://github.com/apache/openmeetings/pull/175#issuecomment-1108398311
And translated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
solomax commented on PR #175:
URL: https://github.com/apache/openmeetings/pull/175#issuecomment-1109418799
I'm using this project to perform export https://github.com/solomax/om-poeditor
This link for view https://poeditor.com/projects/view?id=333773 works for me
You seems to be listed as contributor
I see no way so far how to add you as an admin :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
solomax commented on PR #175:
URL: https://github.com/apache/openmeetings/pull/175#issuecomment-1109445731
well
these dependencies are required at build time only
I've made this helper looong time ago :)
Your Mac seems to unable resolve `~` to home dir
This works as expected at Linux :)
Thanks for the link!
You are admin now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
solomax commented on PR #175:
URL: https://github.com/apache/openmeetings/pull/175#issuecomment-1109241071
@sebawagner @ali-alhaidary I'll do re-import before release
Or by request :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] ali-alhaidary commented on pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
ali-alhaidary commented on PR #175:
URL: https://github.com/apache/openmeetings/pull/175#issuecomment-1110024172
@solomax @sebawagner all done in Arabic :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
sebawagner commented on PR #175:
URL: https://github.com/apache/openmeetings/pull/175#issuecomment-1109377971
I've updated the German transation (I think)
How and where can you export the XML language files in POEditor ? I don't seem to be able to have this options
The instructions here don't seem to cover that case: https://openmeetings.apache.org/Internationalisation.html
I was able to join the project in POEditor: https://poeditor.com/join/project/6UF8Mhql61
But the link to "view" doesn't work for me https://poeditor.com/projects/view?id=333773
How can I export the files from POEditor ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a diff in pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
sebawagner commented on code in PR #175:
URL: https://github.com/apache/openmeetings/pull/175#discussion_r857271393
##########
openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application_de.properties.xml:
##########
@@ -981,4 +981,7 @@ Bitte am OM server {3} anmelden und sie unter Admininistration -> Gruppen prüfe
<entry key="wizard.button.finish"><![CDATA[Ende]]></entry>
<entry key="zoom.FULL_FIT"><![CDATA[Vollformat]]></entry>
<entry key="zoom.PAGE_WIDTH"><![CDATA[Seitenbreite]]></entry>
+ <entry key="wb.add.whiteboard"><![CDATA[Add new whiteboard to conference room]]></entry>
Review Comment:
You mean its not translated ? Cause the strings are there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner merged pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
sebawagner merged PR #175:
URL: https://github.com/apache/openmeetings/pull/175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
sebawagner commented on PR #175:
URL: https://github.com/apache/openmeetings/pull/175#issuecomment-1109440818
Trying ...
mvn exec:java -Dexec.args="~/.token ${OM_SOURCES}/"
But your project fails to run any command:
```
[ERROR] Failed to execute goal on project om-poeditor: Could not resolve dependencies for project org.apache.solomax:om-poeditor:jar:1.0-SNAPSHOT: Could not find artifact org.apache.openmeetings:openmeetings-db:jar:6.0.0 in central (https://repo.maven.apache.org/maven2) -> [Help 1]
```
I changed it then to 7.0.0-SNAPSHOT, which I have in my local ~/.m2 repo since I build this version locally before on the same machine.
But then the new error is:
```
INFO 04-26 19:11:38.498 o.a.solomax.App:221 [omax.App.main()] - Specific language can be specified after 'put', for ex. 'ar'
[WARNING]
java.nio.file.NoSuchFileException: ~/.token
```
But there is a token:
```
sebastianwagner@Sebastians-MacBook-Pro om-poeditor % ls -alh ~/.token
-rw-r--r-- 1 sebastianwagner staff 33B 26 Apr 19:04 /Users/sebastianwagner/.token
```
So I changed the command to:
```
mvn exec:java -Dexec.args="/Users/sebastianwagner/.token ${OM_SOURCES}/"
```
Then the command works but the POEditor response is then the error is:
```
INFO 04-26 19:19:50.885 o.a.c.s.W.RESP_IN:84 [omax.App.main()] - RESP_IN
Address: https://api.poeditor.com/v2/projects/export
Content-Type: application/json; charset=utf-8
ResponseCode: 200
ExchangeId: 70e3fef4-1b6b-4607-ba5b-a2387b223e86
Headers: {Strict-Transport-Security=max-age=31536000; includeSubDomains; preload, Server=Apache/2.4.29 (Ubuntu), content-type=application/json; charset=utf-8, Content-Length=105, Date=Tue, 26 Apr 2022 07:19:50 GMT}
Payload: {"response":{"status":"fail","code":"403","message":"You don't have permission to access this resource"}}
ERROR 04-26 19:19:50.898 o.a.solomax.App:93 [omax.App.main()] - call to projects/export was unsuccessful {"response":{"status":"fail","code":"403","message":"You don't have permission to access this resource"}}
```
Which makes sense cause my API Token is just contributor. I can't export the files via the API
Can you add me as an admin in POEditor:
https://poeditor.com/kb/how-to-add-an-administrator ?
Also we could just setup a Jenkins job to run the job and then create a zip file to download. However the dependency on openmeetings-db-x-x-x.jar will likely fail on Jenkins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
solomax commented on PR #175:
URL: https://github.com/apache/openmeetings/pull/175#issuecomment-1109490869
30 seconds delay is necessary due to poeditor didn't like too many requests :(((
please commit these automatic changes to master
No need to create PR for something generated :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
sebawagner commented on PR #175:
URL: https://github.com/apache/openmeetings/pull/175#issuecomment-1109480607
Will give a try. Why is there a 30sec Thread.sleep after each language file when it fetches it :D
Thanks will open a new PR for the language changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
solomax commented on PR #175:
URL: https://github.com/apache/openmeetings/pull/175#issuecomment-1110830548
@ali-alhaidary merged :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] ali-alhaidary commented on pull request #175: OPENMEETINGS-2727 Add tooltips to whiteboard tab bar buttons and only show scroll button when there is more then 1 whiteboard to scroll
Posted by GitBox <gi...@apache.org>.
ali-alhaidary commented on PR #175:
URL: https://github.com/apache/openmeetings/pull/175#issuecomment-1109042891
yes @sebawagner please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org