You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/03/06 10:53:11 UTC

[GitHub] rafaelweingartner closed pull request #2478: [CLOUDSTACK-10318] Bug on sorting ACL rules list in chrome

rafaelweingartner closed pull request #2478: [CLOUDSTACK-10318] Bug on sorting ACL rules list in chrome
URL: https://github.com/apache/cloudstack/pull/2478
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ui/scripts/vpc.js b/ui/scripts/vpc.js
index 9dc8323e7cd..a77c4d7b585 100644
--- a/ui/scripts/vpc.js
+++ b/ui/scripts/vpc.js
@@ -1325,7 +1325,7 @@
 
                                                     if(items){
                                                         items.sort(function(a, b) {
-                                                            return a.number >= b.number;
+                                                            return a.number - b.number;
                                                         }).map(function(acl) {
                                                             if (parseInt(acl.protocol)) { // protocol number
                                                                 acl.protocolnumber = acl.protocol;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services