[GitHub] [incubator-superset] ktmud commented on a change in pull request #9345: [explore view] fix long query issue from Run in SQL LAB Button

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #9345: [explore view] fix long query issue from Run in SQL LAB Button
URL: https://github.com/apache/incubator-superset/pull/9345#discussion_r396055940
 
 

 ##########
 File path: superset-frontend/src/explore/exploreUtils.js
 ##########
 @@ -190,17 +190,15 @@ export function getExploreUrlAndPayload({
   };
 }
 
-export function exportChart(formData, endpointType) {
-  const { url, payload } = getExploreUrlAndPayload({
-    formData,
-    endpointType,
-    allowDomainSharding: false,
-  });
+export function postForm(url, payload, target = '_blank') {
+  if (!url) {
+    return;
+  }
 
   const exploreForm = document.createElement('form');
   exploreForm.action = url;
   exploreForm.method = 'POST';
-  exploreForm.target = '_blank';
+  exploreForm.target = target;
 
 Review comment:
   Maybe rename `exploreForm` to something more generic. E.g., `hiddenForm`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org