[GitHub] spark pull request #14613: [SPARK-16883][SparkR]:SQL decimal type is not pro...

[wangmiao1981 <gi...@git.apache.org>]

Github user wangmiao1981 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14613#discussion_r77262850
  
    --- Diff: R/pkg/R/types.R ---
    @@ -67,3 +67,27 @@ rToSQLTypes <- as.environment(list(
       "double" = "double",
       "character" = "string",
       "logical" = "boolean"))
    +
    +# Helper function of coverting decimal type. When backend returns column type in the
    +# format of decimal(,) (e.g., decimal(10, 0)), this function coverts the column type
    +# as double type. This function converts backend returned types that are not the key
    +# of PRIMITIVE_TYPES, but should be treated as PRIMITIVE_TYPES.
    +# @param A type returned from the JVM backend.
    +# @return A type is the key of the PRIMITIVE_TYPES.
    +specialtypeshandle <- function(type) {
    +  if (!is.null(PRIMITIVE_TYPES[[type]])) {
    +    type
    +  } else {
    +    firstChar <- substr(type, 1, 1)
    +    returntype <- NULL
    +    switch (firstChar,
    +    d = {
    +      m <- regexec("^decimal(.+)", type)
    --- End diff --
    
    In case, there are other types that we want to handle in the future. Right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org