[GitHub] [incubator-uniffle] wangao1236 commented on a diff in pull request #619: [#618] chore(docker): support downloads latest hadoop archives and mirror url

["wangao1236 (via GitHub)" <gi...@apache.org>]

wangao1236 commented on code in PR #619:
URL: https://github.com/apache/incubator-uniffle/pull/619#discussion_r1109349138


##########
deploy/kubernetes/docker/build.sh:
##########
@@ -51,6 +54,10 @@ while (( "$#" )); do
     --help)
       exit_with_usage
       ;;
+    --apache-mirror)
+      APACHE_MIRROR="$2"

Review Comment:
   Perhaps we can decide not to replace the default value if the value passed in is empty?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org