You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by borxa <gi...@git.apache.org> on 2017/10/12 18:50:23 UTC

[GitHub] incubator-netbeans pull request #134: [NETBEANS-54] Module Review httpserver

GitHub user borxa opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/134

    [NETBEANS-54] Module Review httpserver

    Updated maven coordinates for the external binary.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/borxa/incubator-netbeans master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #134
    
----
commit e03c6cd62263a372fa018c524ebcd50e88cf7aa4
Author: Borxa Varela Bouzas <bo...@varelabouzas.net>
Date:   2017-10-12T18:47:41Z

    [NETBEANS-54] Module Review httpserver

----


---

[GitHub] incubator-netbeans issue #134: [NETBEANS-54] Module Review httpserver

Posted by vieiro <gi...@git.apache.org>.

Github user vieiro commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/134
  
    Hi,
    
    All tests should pass now, but I think the line
    <runtime-relative-path>ext/webserver-3.2.4.jar</runtime-relative-path>
    should look like 
    <runtime-relative-path>ext/webserver.jar</runtime-relative-path>
    
    The "runtime relative path" is the final destination path of the jar when the IDE/platform is built. If this is changed I think that any other modules referring to this jar may fail at runtime



---