You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Tyler Christensen (Jira)" <ji...@apache.org> on 2020/12/02 01:34:00 UTC

[jira] [Created] (THRIFT-5318) PHP 8 compatible version of binary protocol

Tyler Christensen created THRIFT-5318:
-----------------------------------------

             Summary: PHP 8 compatible version of binary protocol
                 Key: THRIFT-5318
                 URL: https://issues.apache.org/jira/browse/THRIFT-5318
             Project: Thrift
          Issue Type: Improvement
          Components: PHP - Library
            Reporter: Tyler Christensen


PHP 8 has been released and [necessitates some changes|https://github.com/php/php-src/blob/PHP-8.0.0/UPGRADING.INTERNALS] to PHP extensions. In the case of thrift_protocol these changes are minor:
 * Update callsites of zend_call_method, zend_read_property, and zend_update_property
 * Add arginfo as requested by PHP 8 migration guide (supports reflection features)

I believe it's possible to do these whilst retaining backwards compatibility with PHP 7; I'll open a PR on Github momentarily.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)