You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/11 14:43:51 UTC

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #357: netutils/ftpc: Embed wdog_s in ftpc_session_s directly

patacongo commented on a change in pull request #357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/357#discussion_r468636359



##########
File path: netutils/ftpc/ftpc_connect.c
##########
@@ -152,8 +148,8 @@ int ftpc_reconnect(FAR struct ftpc_session_s *session)
 
   /* Set up a timer to prevent hangs */
 
-  ret = wd_start(session->wdog,
-                 session->conntimeo, ftpc_timeout, 1, session);
+  ret = wd_start(&session->wdog, session->conntimeo,

Review comment:
       Hmm.. this is another violation of the portable POSIX OS interface.  wd_start(0 is not an application accessible interface.  It is only for use inside the OS.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org