[GitHub] dawidwys commented on a change in pull request #6963: [FLINK-10704] Fix sql client end to end test failure

[GitBox <gi...@apache.org>]

dawidwys commented on a change in pull request #6963: [FLINK-10704] Fix sql client end to end test failure
URL: https://github.com/apache/flink/pull/6963#discussion_r229675258
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common.sh
 ##########
 @@ -316,7 +316,7 @@ function check_logs_for_errors {
       | grep -v "java.lang.NoClassDefFoundError: org/apache/hadoop/yarn/exceptions/YarnException" \
       | grep -v "java.lang.NoClassDefFoundError: org/apache/hadoop/conf/Configuration" \
       | grep -v "org.apache.flink.fs.shaded.hadoop3.org.apache.commons.beanutils.FluentPropertyBeanIntrospector  - Error when creating PropertyDescriptor for public final void org.apache.flink.fs.shaded.hadoop3.org.apache.commons.configuration2.AbstractConfiguration.setProperty(java.lang.String,java.lang.Object)! Ignoring this property." \
-      | grep -ic "error")
+      | grep -c "ERROR")
 
 Review comment:
   First of all I agree this is a bit of a broken design, but the current version is that we do not want to introduce a major rework in the bash scripts. The idea right now is that if test requires some custom validation it should disable the default checking and do it in the test itself, so that this decision is a conscious one.
   
   Having that in mind:
   - I would definitely leave the case sensitivity as it is
   - If you don't want to extend the global list, in other words if you don't want to rely on the default behavior I would disable the log checking via #6959 and add a custom check in the test itself that verifies logs with your extended whitelist (preferably in a trap invoked on exit). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services