You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Manyanda Chitimbo (Jira)" <ji...@apache.org> on 2023/05/10 16:44:00 UTC
[jira] [Commented] (KAFKA-14985) ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() test is flaky
[ https://issues.apache.org/jira/browse/KAFKA-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721469#comment-17721469 ]
Manyanda Chitimbo commented on KAFKA-14985:
-------------------------------------------
A quick fix will be to bump the epsilon to a bigger value e.g 8 on [https://github.com/apovzner/kafka/blob/508a754f397b5a1939c44dfcba72ba996bc912c5/core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala#L400] but I am not sure if that's enough to make the test resilient , what do you think [~apovzner] ?
> ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() test is flaky
> --------------------------------------------------------------------------------------------
>
> Key: KAFKA-14985
> URL: https://issues.apache.org/jira/browse/KAFKA-14985
> Project: Kafka
> Issue Type: Test
> Reporter: Manyanda Chitimbo
> Priority: Major
>
> The test sometimes fails with the following error
> {code:java}
> Gradle Test Run :core:test > Gradle Test Executor 14 > ConnectionQuotasTest > testListenerConnectionRateLimitWhenActualRateAboveLimit() FAILED
> java.util.concurrent.ExecutionException: org.opentest4j.AssertionFailedError: Expected rate (30 +- 7), but got 37.47891810856393 (600 connections / 16.009 sec) ==> expected: <30.0> but was: <37.47891810856393>
> at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
> at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:205)
> at kafka.network.ConnectionQuotasTest.$anonfun$testListenerConnectionRateLimitWhenActualRateAboveLimit$3(ConnectionQuotasTest.scala:412)
> at scala.collection.immutable.List.foreach(List.scala:333)
> at kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit(ConnectionQuotasTest.scala:412) Caused by:
> org.opentest4j.AssertionFailedError: Expected rate (30 +- 7), but got 37.47891810856393 (600 connections / 16.009 sec) ==> expected: <30.0> but was: <37.47891810856393>
> at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
> at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
> at app//org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
> at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:86)
> at app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1021)
> at app//kafka.network.ConnectionQuotasTest.acceptConnectionsAndVerifyRate(ConnectionQuotasTest.scala:904)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)