You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2023/04/12 00:56:47 UTC
[GitHub] [pinot] Jackie-Jiang opened a new pull request, #10593: Check EV not exist before allowing creating the table
Jackie-Jiang opened a new pull request, #10593:
URL: https://github.com/apache/pinot/pull/10593
In #8422 we introduced the table delete message to delete a table on the server, and server will wait for EV to disappear then cleaning up the table data manager. We should not allow re-creating the table before EV is deleted to ensure that logic doesn't break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10593: Check EV not exist before allowing creating the table
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #10593:
URL: https://github.com/apache/pinot/pull/10593#discussion_r1166050424
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -450,20 +451,26 @@ private void deleteSchemaInternal(String schemaName) {
}
// If the schema is associated with a table, we should not delete it.
- List<String> tableNames = _pinotHelixResourceManager.getAllRealtimeTables();
- for (String tableName : tableNames) {
- TableConfig config = _pinotHelixResourceManager.getRealtimeTableConfig(tableName);
- String tableSchema = config.getValidationConfig().getSchemaName();
-
- if (schemaName.equals(tableSchema)) {
+ // TODO: Check OFFLINE tables as well
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] KKcorps commented on a diff in pull request #10593: Check EV not exist before allowing creating the table
Posted by "KKcorps (via GitHub)" <gi...@apache.org>.
KKcorps commented on code in PR #10593:
URL: https://github.com/apache/pinot/pull/10593#discussion_r1165627796
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -450,20 +451,26 @@ private void deleteSchemaInternal(String schemaName) {
}
// If the schema is associated with a table, we should not delete it.
- List<String> tableNames = _pinotHelixResourceManager.getAllRealtimeTables();
- for (String tableName : tableNames) {
- TableConfig config = _pinotHelixResourceManager.getRealtimeTableConfig(tableName);
- String tableSchema = config.getValidationConfig().getSchemaName();
-
- if (schemaName.equals(tableSchema)) {
+ // TODO: Check OFFLINE tables as well
Review Comment:
What is the blocker for not implementing for OFFLINE tables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10593: Check EV not exist before allowing creating the table
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10593:
URL: https://github.com/apache/pinot/pull/10593#issuecomment-1505833943
## [Codecov](https://codecov.io/gh/apache/pinot/pull/10593?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10593](https://codecov.io/gh/apache/pinot/pull/10593?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6331def) into [master](https://codecov.io/gh/apache/pinot/commit/7c1d10a358b4974b3ddc0b56c8d4328e0d6d579c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c1d10a) will **decrease** coverage by `36.87%`.
> The diff coverage is `41.66%`.
```diff
@@ Coverage Diff @@
## master #10593 +/- ##
=============================================
- Coverage 69.04% 32.17% -36.87%
+ Complexity 6496 453 -6043
=============================================
Files 2106 2106
Lines 113004 113008 +4
Branches 17026 17028 +2
=============================================
- Hits 78021 36362 -41659
- Misses 29495 73365 +43870
+ Partials 5488 3281 -2207
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `24.51% <0.00%> (?)` | |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `13.88% <41.66%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/10593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ller/api/resources/PinotSchemaRestletResource.java](https://codecov.io/gh/apache/pinot/pull/10593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90U2NoZW1hUmVzdGxldFJlc291cmNlLmphdmE=) | `68.32% <10.00%> (-1.30%)` | :arrow_down: |
| [...ler/api/resources/TableConfigsRestletResource.java](https://codecov.io/gh/apache/pinot/pull/10593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1RhYmxlQ29uZmlnc1Jlc3RsZXRSZXNvdXJjZS5qYXZh) | `79.34% <50.00%> (-0.23%)` | :arrow_down: |
| [...ntroller/helix/core/PinotHelixResourceManager.java](https://codecov.io/gh/apache/pinot/pull/10593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1Bpbm90SGVsaXhSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `69.36% <70.00%> (-0.97%)` | :arrow_down: |
... and [1394 files with indirect coverage changes](https://codecov.io/gh/apache/pinot/pull/10593/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10593: Check EV not exist before allowing creating the table
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10593:
URL: https://github.com/apache/pinot/pull/10593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10593: Check EV not exist before allowing creating the table
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #10593:
URL: https://github.com/apache/pinot/pull/10593#discussion_r1165869470
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -450,20 +451,26 @@ private void deleteSchemaInternal(String schemaName) {
}
// If the schema is associated with a table, we should not delete it.
- List<String> tableNames = _pinotHelixResourceManager.getAllRealtimeTables();
- for (String tableName : tableNames) {
- TableConfig config = _pinotHelixResourceManager.getRealtimeTableConfig(tableName);
- String tableSchema = config.getValidationConfig().getSchemaName();
-
- if (schemaName.equals(tableSchema)) {
+ // TODO: Check OFFLINE tables as well
Review Comment:
The main concern is that this is behavior change, and out of the scope of this PR. We can address this separately if desired, but need to explicitly call out this behavior change. Thus left a TODO so that people aware of this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] KKcorps commented on a diff in pull request #10593: Check EV not exist before allowing creating the table
Posted by "KKcorps (via GitHub)" <gi...@apache.org>.
KKcorps commented on code in PR #10593:
URL: https://github.com/apache/pinot/pull/10593#discussion_r1165933900
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -450,20 +451,26 @@ private void deleteSchemaInternal(String schemaName) {
}
// If the schema is associated with a table, we should not delete it.
- List<String> tableNames = _pinotHelixResourceManager.getAllRealtimeTables();
- for (String tableName : tableNames) {
- TableConfig config = _pinotHelixResourceManager.getRealtimeTableConfig(tableName);
- String tableSchema = config.getValidationConfig().getSchemaName();
-
- if (schemaName.equals(tableSchema)) {
+ // TODO: Check OFFLINE tables as well
Review Comment:
I think we should mention this in the TODO as well, why it was not implemented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org