You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by li...@apache.org on 2024/03/27 19:56:07 UTC
(superset) branch table-time-comparison-color updated (7e02a156fa -> c5f909ecf1)
This is an automated email from the ASF dual-hosted git repository.
lilykuang pushed a change to branch table-time-comparison-color
in repository https://gitbox.apache.org/repos/asf/superset.git
discard 7e02a156fa update tooltip
new c5f909ecf1 update tooltip
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (7e02a156fa)
\
N -- N -- N refs/heads/table-time-comparison-color (c5f909ecf1)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx | 3 +++
superset-frontend/plugins/plugin-chart-table/src/types.ts | 1 +
2 files changed, 4 insertions(+)
(superset) 01/01: update tooltip
Posted by li...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
lilykuang pushed a commit to branch table-time-comparison-color
in repository https://gitbox.apache.org/repos/asf/superset.git
commit c5f909ecf13eb64f70ae2aac61488c316657686b
Author: lilykuang <ji...@gmail.com>
AuthorDate: Wed Mar 27 12:46:03 2024 -0700
update tooltip
---
.../plugins/plugin-chart-table/src/controlPanel.tsx | 13 ++++++++++---
superset-frontend/plugins/plugin-chart-table/src/types.ts | 1 +
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
index 641445913b..b76abde8ca 100644
--- a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
+++ b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
@@ -601,10 +601,17 @@ const config: ControlPanelConfig = {
name: 'comparison_color_enabled',
config: {
type: 'CheckboxControl',
- label: t('basic conditional formatting for comparison '),
+ label: t('basic conditional formatting'),
renderTrigger: true,
+ visibility: ({ controls }) =>
+ Boolean(controls?.enable_time_comparison?.value) &&
+ isFeatureEnabled(FeatureFlag.ChartPluginsExperimental),
default: false,
- description: t('Add color for positive/negative change'),
+ description: t(
+ 'This will be applied to the whole table. Arrows (↑ and ↓) will be added to ' +
+ 'main columns for increase and decrease. Basic conditional formatting can be ' +
+ 'overwritten by conditional formatting below.',
+ ),
},
},
],
@@ -613,7 +620,7 @@ const config: ControlPanelConfig = {
name: 'comparison_color_scheme',
config: {
type: 'SelectControl',
- label: t('color scheme for comparison'),
+ label: t('color type'),
default: ColorSchemeEnum.Green,
renderTrigger: true,
choices: [
diff --git a/superset-frontend/plugins/plugin-chart-table/src/types.ts b/superset-frontend/plugins/plugin-chart-table/src/types.ts
index e8f2ae3f0a..3f77f9c1cb 100644
--- a/superset-frontend/plugins/plugin-chart-table/src/types.ts
+++ b/superset-frontend/plugins/plugin-chart-table/src/types.ts
@@ -108,6 +108,7 @@ export type BasicColorFormatterType = {
arrowColor: string;
mainArrow: string;
};
+
export interface TableChartTransformedProps<D extends DataRecord = DataRecord> {
timeGrain?: TimeGranularity;
height: number;