You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/23 14:01:40 UTC

[GitHub] [incubator-nuttx] patacongo opened a new issue #1880: Cygwin directories not being cleaned

patacongo opened a new issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880


   Under Cygwin, the following directories are not being removed by the distclean target:
   
       arch/<arch>/src/board
       arch/<arch>/src/chip
   
   I have several old board and and chip directories left over from unsuccessful distclean operations on different architectures.  These two lines in arch/arm/src/Makefile (and other arch Makefiles) are not apparaently not working under Cygwin:
   
            $(Q) $(DIRUNLINK) $(ARCH_SRC)/board
            $(Q) $(DIRUNLINK) $(ARCH_SRC)/chip
   
   Cygwin supports is own style of symbolic links and these are used EXCEPT for the case where a Windows native toolchain is used such as the popular (https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-rm).
   
   Those are Window native tools and cannot follow non-standard Cygwin symbolic links so in this case, the tools/dirlinks.sh script does a full directory copy and the corresponding unlink script does a directory removal.
   
   Without knowing more, it looks like the DIRUNLINK is failing to remove the Cygwin symbolic link or the copied directory.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697545869

Aha... these bad directories are being created by configure.sh.

$ make distclean (and verify that there are no chip or board directories)
$ tools/configure.sh -c stm32f4discovery:nsh
$ find . -name board
./arch/arm/include/board
./arch/arm/src/board
./boards/arm/stm32/common/board
$ find . -name chip
./arch/arm/include/chip
./arch/arm/src/chip

@v01d @btashton This is a consequence of several changes to the Makefiles recently:

- The olddefconfig target used to invoke the clean_context target to remove all residuals from the configuration
- The symbolic links are (probably) created because CONFIG_CYGWIN_WINTOOL has not been selected yet in the configuration (it was initially a Linux configuration). The .config included by the Makefile is the original defconfig file and does not yet have the derived settings like CONFIG_CYGWIN_WINTOOL.=y. So the Makefile runs without sufficient information.
- The logic that removes these links was removed from its correct location in the clean_context target to the distclean target.

A possible fix would be to restore the 'make clean_context' and all reconfigurations to eliminate this garbage from running the Makefile with an incomplete configuration. The old, fully working logic in Makefile.unix was:

do_olddefconfig: dirlinks apps_preconfig
$(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf --olddefconfig Kconfig

olddefconfig: do_olddefconfig clean_context

Where clean_context removed the bad settings left by the 'make olddefconfig' setup. Restoring this code would not fully work, however. You would also have to restore the correct behavior or clean_context since the key clean up was more to the distclean target.

I will never understand why people intentionally break full working, well tested code with no real justification.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

btashton commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697939341


   My inclination is for it to be a blocker because I cannot enable windows CI without it and I would like to see that pass prior to the releases. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697407337


   I don't think this bug has been introduced recently.  I have not build the ez80 (under arch/z80) in many months.
   
   I will do this as part of the review for the 10.0.0 release.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698643435


   The MYS2 build is similar in that it must copy directories since MSYS2 does not support any kind of symbolic linking.  However, it does not depend on CONFIG_CYGWIN_WINTOOL so should not suffer from this issue.
   
   After you decide on the correct change and before releasing 10.0.0, I will verify the MSYS2 build as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697449496


   The stranded directories are NOT the directory copies, but Cygwin symbolic links:
   
       $ ls -ld arch/arm/include/chip
       lrwxrwxrwx 1 spuda spuda 83 Aug 30 10:09 arch/arm/include/chip -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/arch/arm/include/stm32
   
   When I do
   
       make distclean
       tools/configures.sh -c stm32f4discovery:nsh
       make context
   
   I get the expected copied directories (because I am using the Arm Embedded toolchain and CONFIG_CYGWIN_WINTOOL=y):
   
       $ ls -ld include/arch
       drwxrwxr-x+ 1 spuda spuda 0 Sep 23 08:43 include/arch
       
       $ ls -ld include/arch/board
       drwxrwxr-x+ 1 spuda spuda 0 Sep 23 08:43 include/arch/board
       
       $ ls -ld include/arch/chip
       ddrwxrwxr-x+ 1 spuda spuda 0 Sep 23 08:43 include/arch/chip
   
   Bit I also get Cygwin Symbolic links:
   
       $ ls -ld arch/arm/include/chip
       lrwxrwxrwx 1 spuda spuda 83 Sep 23 08:42 arch/arm/include/chip -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/arch/arm/include/stm32
       
       $ ls -ld arch/arm/include/board
       lrwxrwxrwx 1 spuda spuda 102 Sep 23 08:42 arch/arm/include/board -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/boards/arm/stm32/stm32f4discovery/include
   
   That should not be happening and exonerates the DIRUNLINK calls implicated in the Issue description.  These symbolic links are being created erroneously sometime in the context target.
   
   Doing 'make clean_context' does not remove any of those.  That is an error.  'make clean_context' should undo everything that was done my 'make context'.  Apparently, somewhere along the way that critical part of the clean_context target got moved to distclean, breaking the symmetry of the make targets.
   
   When I do 'make distclean' the unexpected Cygwin symbolic links remain:
   
       $ find . -name chip
       ./arch/arm/include/chip
   
       $ find . -name board
       ./arch/arm/include/board
       ./boards/arm/stm32/common/board
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698512974


   There are multiple causes of the Cygwin CI build breakage.  This commit is also a factor:  bd656888f26c92e8832f0e76b395a5ece7704530  Although the other cited commits leave the system with a bad context setup, that would not have been noticed prior to this commit which changes the WINTOOL variable to the CONFIG_CYGWIN_WINTOOL Kconfig setting.  Previously WINTOOL would have been defined; bue CONFIG_CYGWIN_WINTOOL will not be defined (since it is the default and will not be in the defconfig).
   
   That is three commits that break the Cygwin CI build.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo removed a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo removed a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697425224


   Hmmm... This is not so simple to replicate.  I don't know the incantation that creates the problem.  My simple tests seems to work.  But the existence of the old, stale, links and the problems described in apache/incubator-nuttx-testing#39 indicate that the problem is real.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697407337


   I don't think this bug has been introduced recently.  I have not build the ez80 (under arch/z80) in many months.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697545869

Aha... these bad directories are being created by configure.sh.

@v01d @btashton This is a consequence of several changes to the Makefiles recently:

do_olddefconfig: dirlinks apps_preconfig
$(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf --olddefconfig Kconfig

olddefconfig: do_olddefconfig clean_context

These are the commits that broke the Cygwin build: b5dc83748c0 and c709ed24646 Parts of those changes need to be reverted.

I will never understand why people intentionally break full working, well tested code with no real justification.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697545869

Aha... these bad directories are being created by configure.sh.

@v01d @btashton This is a consequence of several changes to the Makefiles recently:

A possible fix would be to restore the 'make clean_context' and all reconfigurations to eliminate this garbage from running the Makefile with an incomplete configuration.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] liuguo09 commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

liuguo09 commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-699631674


   @patacongo @btashton I have made a draft PR https://github.com/apache/incubator-nuttx/pull/1901 Could you help to review and verify it? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698053956


   One solution that I would NOT recommend is modify the distclean target to clean more symbolic links.  That is a bandaid and not a really solution to the generic problem that a defconfig is not a valid .config file and can cause problems when used as one in the Makefile.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697449496


   The stranded directories are NOT the directory copies, but Cygwin symbolic links:
   
       $ ls -ld arch/arm/include/chip
       lrwxrwxrwx 1 spuda spuda 83 Aug 30 10:09 arch/arm/include/chip -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/arch/arm/include/stm32
   
   When I do
   
       make distclean
       tools/configures.sh -c stm32f4discovery:nsh
       make context
   
   I get the expected copied directories (because I am using the Arm Embedded toolchain and CONFIG_CYGWIN_WINTOOL=y):
   
       $ ls -ld include/arch
       drwxrwxr-x+ 1 spuda spuda 0 Sep 23 08:43 include/arch
       
       $ ls -ld include/arch/board
       drwxrwxr-x+ 1 spuda spuda 0 Sep 23 08:43 include/arch/board
       
       $ ls -ld include/arch/chip
       ddrwxrwxr-x+ 1 spuda spuda 0 Sep 23 08:43 include/arch/chip
   
   Bit I also get Cygwin Symbolic links:
   
       $ ls -ld arch/arm/include/chip
       lrwxrwxrwx 1 spuda spuda 83 Sep 23 08:42 arch/arm/include/chip -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/arch/arm/include/stm32
       
       $ ls -ld arch/arm/include/board
      lrwxrwxrwx 1 spuda spuda 102 Sep 23 08:42 arch/arm/include/board -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/boards/arm/stm32/stm32f4discovery/include
   
   That should not be happening and exonerates the DIRUNLINK calls implicated in the Issue description.  These symbolic links are being created erroneously sometime in the context target.
   
   Doing 'make clean_context' does not remove any of those.  That is an error.  'make clean_context' should undo everything that was done my 'make context'.  Apparently, somewhere along the way that critical part of the clean_context target got moved to distclean, breaking the symmetry of the make targets.
   
   When I do 'make distclean' the unexpected Cygwin symbolic links remain:
   
       $ find . -name chip
       ./arch/arm/include/chip
   
       $ find . -name board
       ./arch/arm/include/board
       ./boards/arm/stm32/common/board
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698242052


   @patacongo we are looking this problem.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] liuguo09 commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

liuguo09 commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698634812


   @patacongo @btashton @xiaoxiang781216  It seems cygwin build using copydir.sh as DIRLINK in tools/Config.mk. In cygwin case, there are two copies: include/arch/chip and arch/arm/include/chip. And it finally only clean include/arch/chip. So could we switch to use link.sh as DIRLINK for cygwin build to keep one copy firstly? I have tested using link.sh locally and distclean verify ok. As to copydir.sh case, it may need separate out a clean_links target as @patacongo suggests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698642242


   This is a consequence of:
   
   - Replace the WINTOOL definition with the CONFIG_CYGWIN_WINTOOL configuration. WINTOOL was always defined previously.
   - Removing the olddefconfig dependency on clean_context which removed the context (that removed too much, it is only necessary to remove the bad links)
   - And, related, removing the logic that removes the links from the clean_context target.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697425224


   Hmmm... This is not so simple to replicate.  I don't know the incantation that creates the problem.  My simple tests seems to work.  But the existence of the old, stale, links and the problems described in apache/incubator-nuttx-testing#39 indicate that the problem is real.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697959768


   > I don't think it needs to be a blocker, but maybe Good First Issue?
   
   Way to complex and risky for a first issue.  I don't even know how to solve it without coordination with Xiaomi guys.  @xiaoxiang781216 I think we need to wait and at least get a recommendation (and preferably a draft PR).  If you create the draft PR, I will check it out.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] hartmannathan commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

hartmannathan commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697906438


   I don't think it needs to be a blocker, but maybe Good First Issue?
   
   On Wed, Sep 23, 2020 at 2:56 PM patacongo <no...@github.com> wrote:
   
   > @btashton <https://github.com/btashton> @hartmannathan
   > <https://github.com/hartmannathan> Should this be marked a blocker? I had
   > it tagged that way, but decided not.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697887633>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AOD4O54Q2XGH7DSXDQEAP7TSHJAGXANCNFSM4RXCOPEQ>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697405257


   The dir unlink script seems to be working fine, however (at least using a relative path):
   
       $ find . -name chip
       ./arch/arm/include/chip
       ./arch/arm/src/chip
       ./arch/z80/include/chip
       ./include/arch/chip
       
       $ tools/unlink.sh ./arch/z80/include/chip
       
       $ find . -name chip
       ./arch/arm/include/chip
       ./arch/arm/src/chip
       ./include/arch/chip
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698512974






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] liuguo09 commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

liuguo09 commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698634812


   @patacongo @btashton @xiaoxiang781216  It seems cygwin build using copydir.sh as DIRLINK in tools/Config.mk. In cygwin case, there are two copies: include/arch/chip and arch/arm/include/chip. And it finally only clean include/arch/chip. So could we switch to use link.sh as DIRLINK for cygwin build to keep one copy firstly? I have tested using link.sh locally and distclean verify ok. As to copydir.sh case, it may need separate out a clean_links target as @patacongo suggests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698242052


   @patacongo we are looking this problem.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697959768


   > I don't think it needs to be a blocker, but maybe Good First Issue?
   
   Way to complex and risky for a first issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698011358


   There could also be other issues in the created context.  Some configurations do much more than just setup links.  They may, for example, auto-generate files based on the current configuration.
   
   When a defconfig is included by the Makefile as the .config, it is an incomplete and invalid configuration.  This could potentially cause other more serious problems than just some extra bogus soft links.  It is just not a good behavior.
   
   That is why clean_context was invoked before.  To eliminate any potentially bad context created during 'make olddefconfig' or 'make memconfig'.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697545869

Aha... these bad directories are being created by configure.sh.

@v01d @btashton This is a consequence of several changes to the Makefiles recently:

- The olddefconfig target used to invoke the clean_context target to remove all residuals from the configuration
- The symbolic links are (probably) created because CONFIG_CYGWIN_WINTOOL has not been selected yet in the configuration (it was initially a Linux configuration). The .config included by the Makefile is the original defconfig file and does not yet have the derived settings like CONFIG_CYGWIN_WINTOOL.=y. So the Makefile runs without sufficient information.
- The logic that removes these incorrect links was removed from its correct location in the clean_context target to the distclean target.

do_olddefconfig: dirlinks apps_preconfig
$(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf --olddefconfig Kconfig

olddefconfig: do_olddefconfig clean_context

These are the commits that broke the Cygwin build: b5dc83748c0 and c709ed24646 Parts of those changes need to be reverted.

I will never understand why people intentionally break full working, well tested code with no real justification.

@xiaoxiang781216 Can you discuss this with @liuguo09 and @anchao? It is their commits together that break the Cygwin build. I am hesitant to restore this necessary logic sense I cannot know their intent with these changes.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo closed issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo closed issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo closed issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo closed issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698512974


   There are multiple causes of the Cygwin CI build breakage.  This commit is also a factor:  bd656888f26c92e8832f0e76b395a5ece7704530  Although the other cited commits leave the system with a bad context setup, that would not have been noticed prior to this commit which changes the WINTOOL variable to the CONFIG_CYGWIN_WINTOOL Kconfig setting.  Previously WINTOOL would have been defined; bue CONFIG_CYGWIN_WINTOOL will not be defined (since it is the default and will not be in the defconfig).
   
   That is three commits that break the Cygwin CI build.  But b5dc837  is the real culprit because it allows bad context setups into the system.  That could introduce wide-reaching problems.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698640629


   > 
   > 
   > @patacongo @btashton @xiaoxiang781216 It seems cygwin build using copydir.sh as DIRLINK in tools/Config.mk. In cygwin case, there are two copies: include/arch/chip and arch/arm/include/chip. And it finally only clean include/arch/chip. So could we switch to use link.sh as DIRLINK for cygwin build to keep one copy firstly? I have tested using link.sh locally and distclean verify ok. As to copydir.sh case, it may need separate out a clean_links target as @patacongo suggests.
   
   The Cygwin build does NOT use copydir.sh unless CONFIG_CYGWIN_WINTOOL is selected.   That is the problem.
   
   - Then Make runs during configuration, it includes .config.  But that is not  complete configuration file.  It is a defconfig file.
   - CONFIG_CYGWIN_WINTOOL is the default setting for the selected toolchain so it is NOT selected in the .config file
   - As a result, the dirlinks target uses symbolic links to create the links (WRONG)
   - After configuring, CONFIG_CYGWIN_WINTOOL will be be defined in the expanded, complete .config file
   - The next time Make runs, copydir.sh re-creates all of links with directory copy copies EXCEPT for the two links at arch/arm/include/chip and arch/arm/include/board.  Those are NOT replaced because the directory is copied into include/arch/board and include/arch/chip (the symbolic links are probably copied into include/arch as well (ALSO WRONG)
   - When 'make distclean' removes the links, the bad links at include/arch/board and include/arch/chip are not removed because the link target is include/arch/chip and  include/arch/board.  Hence, those two symbolic links are stranded and the CI build fails.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697545869

Aha... these bad directories are being created by configure.sh.

@v01d @btashton This is a consequence of several changes to the Makefiles recently:

do_olddefconfig: dirlinks apps_preconfig
$(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf --olddefconfig Kconfig

olddefconfig: do_olddefconfig clean_context

These are the commits that broke the Cygwin build: b5dc83748c0 and c709ed24646 Parts of those changes need to be reverted.

I will never understand why people intentionally break full working, well tested code with no real justification.

@xiaoxiang781216 Can you discuss this with @liuguo09 and @anchao? It is their commits together that break the Cygwin build.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697449496


   The stranded directories are NOT the directory copies, but Cygwin symbolic links:
   
       $ ls -ld arch/arm/include/chip
       lrwxrwxrwx 1 spuda spuda 83 Aug 30 10:09 arch/arm/include/chip -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/arch/arm/include/stm32
   
   When I do
   
       make distclean
       tools/configures.sh -c stm32f4discovery:nsh
       make context
   
   I get the expected copied directories (because I am using the Arm Embedded toolchain and CONFIG_CYGWIN_WINTOOL=y):
   
       $ ls -ld include/arch
       drwxrwxr-x+ 1 spuda spuda 0 Sep 23 08:43 include/arch
       
       $ ls -ld include/arch/board
       drwxrwxr-x+ 1 spuda spuda 0 Sep 23 08:43 include/arch/board
       
       $ ls -ld include/arch/chip
       ddrwxrwxr-x+ 1 spuda spuda 0 Sep 23 08:43 include/arch/chip
   
   Bit I also get Cygwin Symbolic links:
   
       $ ls -ld arch/arm/include/chip
       lrwxrwxrwx 1 spuda spuda 83 Sep 23 08:42 arch/arm/include/chip -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/arch/arm/include/stm32
       
       $ ls -ld arch/arm/include/board
      lrwxrwxrwx 1 spuda spuda 102 Sep 23 08:42 arch/arm/include/board -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/boards/arm/stm32/stm32f4discovery/include
   
   That should not be happening.
   
   Doing 'make clean_context' does not remove any of those.  That is an error.  'make clean_context' should undo everything that was done my 'make context'.  Apparently, somewhere along the way that critical part of the clean_context target got moved to distclean, breaking the symmetry of the make targets.
   
   When I do 'make distclean' the unexpected Cygwin symbolic links remain:
   
       $ find . -name chip
       ./arch/arm/include/chip
   
       $ find . -name board
       ./arch/arm/include/board
       ./boards/arm/stm32/common/board
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698642242


   This is a consequence of:
   
   - Replaceingthe WINTOOL definition with the CONFIG_CYGWIN_WINTOOL configuration. WINTOOL was always defined previously.
   - Removing the olddefconfig dependency on clean_context which removed the context (that removed too much, it is only necessary to remove the bad links)
   - And, related, removing the logic that removes the links from the clean_context target.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697408213


   I hate the close button being associated with the comment window!!!!!!!!!!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697449496


   The stranded directories are NOT the directory copies, but Cygwin symbolic links:
   
       $ ls -ld arch/arm/include/chip
       lrwxrwxrwx 1 spuda spuda 83 Aug 30 10:09 arch/arm/include/chip -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/arch/arm/include/stm32
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697449496


   The stranded directories are NOT the directory copies, but Cygwin symbolic links:
   
       $ ls -ld arch/arm/include/chip
       lrwxrwxrwx 1 spuda spuda 83 Aug 30 10:09 arch/arm/include/chip -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/arch/arm/include/stm32
   
   When I do
   
      make distclean
      tools/configures.sh -c stm32f4discovery:nsh
      make context
   
   I get the expected copied directories (because I am using the Arm Embedded toolchain and CONFIG_CYGWIN_WINTOOL=y):
   
       $ ls -ld include/arch
       drwxrwxr-x+ 1 spuda spuda 0 Sep 23 08:43 include/arch
       
       $ ls -ld include/arch/board
       drwxrwxr-x+ 1 spuda spuda 0 Sep 23 08:43 include/arch/board
       
       $ ls -ld include/arch/chip
       ddrwxrwxr-x+ 1 spuda spuda 0 Sep 23 08:43 include/arch/chip
   
   Bit I also get Cygwin Symbolic links:
   
       $ ls -ld arch/arm/include/chip
       lrwxrwxrwx 1 spuda spuda 83 Sep 23 08:42 arch/arm/include/chip -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/arch/arm/include/stm32
       
       $ ls -ld arch/arm/include/board
      lrwxrwxrwx 1 spuda spuda 102 Sep 23 08:42 arch/arm/include/board -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/boards/arm/stm32/stm32f4discovery/include
   
   That should not be happening.
   
   Doing 'make clean_context' does not remove any of those.  That is an error.  'make clean_context' should undo everything that was done my 'make context'.  Apparently, somewhere along the way that critical part of the clean_context target got moved to distclean, breaking the symmetry of the make targets.
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697545869

Aha... these bad directories are being created by configure.sh.

@v01d @btashton This is a consequence of several changes to the Makefiles recently:

- The olddefconfig target used to invoke the clean_context target to remove all residuals from the configuration
- The symbolic links are (probably) created because CONFIG_CYGWIN_WINTOOL has not been selected yet in the configuration (it was initially a Linux configuration). The .config included by the Makefile is the original defconfig file and does not yet have the derived settings like CONFIG_CYGWIN_WINTOOL.=y. So the Makefile runs without sufficient information.
- The logic that removes these incorrect links was removed from its correct location in the clean_context target to the distclean target.

do_olddefconfig: dirlinks apps_preconfig
$(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf --olddefconfig Kconfig

olddefconfig: do_olddefconfig clean_context

These are the commits that broke the Cygwin build: b5dc83748c0 and c709ed24646 Parts of those changes need to be reverted.

I will never understand why people intentionally break full working, well tested code with no real justification.

@xiaoxiang781216 Can you discuss this with @liuguo09 and @anchao? It is their commits together that break the Cygwin build.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698580874


   >  But [b5dc837](https://github.com/apache/incubator-nuttx/commit/b5dc83748c0d28e4310655177419a51412ade07d) is the real culprit because it allows bad context setups into the user build. That could introduce wide-reaching, difficult to analyze problems.
   
   Actually I think I am mistaken about this:  that commit does not do the full context.  It only does dirlinks as far as I can tell.  If that is the case, then things are not so bad.  Perhaps we just need to separate out a clean_links target to get rid of those links, just as clean_context was called previously.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697449496


   The stranded directories are NOT the directory copies, but Cygwin symbolic links:
   
       $ ls -ld arch/arm/include/chip
       lrwxrwxrwx 1 spuda spuda 83 Aug 30 10:09 arch/arm/include/chip -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/arch/arm/include/stm32
   
   When I do
   
      make distclean
      tools/configures.sh -c stm32f4discovery:nsh
      make context
   
   I get the expected copied directories (because I am using the Arm Embedded toolchain and CONFIG_CYGWIN_WINTOOL=y):
   
       $ ls -ld include/arch
       drwxrwxr-x+ 1 spuda spuda 0 Sep 23 08:31 include/arch
       
       $ ls -ld include/arch/board
       drwxrwxr-x+ 1 spuda spuda 0 Sep 23 08:31 include/arch/board
       
       $ ls -ld include/arch/chip
       drwxrwxr-x+ 1 spuda spuda 0 Sep 23 08:31 include/arch/chip
   
   Bit I also get Cygwin Symbolic links:
   
       $ ls -ld arch/arm/include/chip
       lrwxrwxrwx 1 spuda spuda 83 Aug 30 10:09 arch/arm/include/chip -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/arch/arm/include/stm32
       
       $ ls -ld arch/arm/include/board
       lrwxrwxrwx 1 spuda spuda 102 Aug 30 10:09 arch/arm/include/board -> /cygdrive/d/Spuda/Documents/projects/nuttx/master/nuttx_fork/boards/arm/stm32/stm32f4discovery/include
   
   That should not be happening.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697545869

Aha... these bad directories are being created by configure.sh.

@v01d @btashton This is a consequence of several changes to the Makefiles recently:

A possible fix would be to restore the 'make clean_context' and all reconfigurations to eliminate this garbage from running the Makefile with an incomplete configuration.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698512974






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] hartmannathan commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

hartmannathan commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697952620


   > My inclination is for it to be a blocker because I cannot enable windows CI without it and I would like to see that pass prior to the releases.
   
   Okay in that case, make it a blocker. With the Windows CI working, we will find out about breakage much more quickly. That will be a good thing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697545869


   Aha... these bad directories are being created by configure.sh.
   
       $ make distclean (and verify that there are no chip or board directories)
       $ tools/configure.sh -c stm32f4discovery:nsh
       $ find . -name board
       ./arch/arm/include/board
       ./arch/arm/src/board
       ./boards/arm/stm32/common/board
   
   @v01d @btashton This is a consequence of several changes to the Makefiles recently:
   
   - The olddefconfig target used to invoke the clean_context target to remove all residuals from the configuration
   - The symbolic links are (probably) created because CONFIG_CYGWIN_WINTOOL has not been selected yet in the configuration (it was initially a Linux configuration).
   - The logic that removes these links was removed from its correct location in the clean_context target to the distclean target.
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698011358


   There could also be other issues in the created context.  Some configurations do much more than just setup links.  They may, for example, auto-generate files based on the current configuration.
   
   When a defconfig is included by the Makefile as the .config, it is an incomplete and invalid configuration.  This could potentially cause other more serious configuration problems than just some extra bogus soft links.  It is just not a good behavior.
   
   That is why clean_context was invoked before.  To eliminate this potentially bad configuration.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698580874


   >  But [b5dc837](https://github.com/apache/incubator-nuttx/commit/b5dc83748c0d28e4310655177419a51412ade07d) is the real culprit because it allows bad context setups into the user build. That could introduce wide-reaching, difficult to analyze problems.
   
   Actually I think I am mistaken about this:  that commit does not do the full context.  It only does dirlinks as far as I can tell.  If that is the case, then things are not so bad.  We just need to separate out a clean_links target to get rid of those links.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698512974


   There are multiple causes of the Cygwin build breakage.  This commit is also a factor:  bd656888f26c92e8832f0e76b395a5ece7704530  Although the other cited commits leave the system with a bad context setup, that would not have been noticed prior to this commit which changes the WINTOOL variable to the CYGWIN_WINTOOL Kconfig setting.
   
   That is three commits that break the Cygwin CI build.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo removed a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo removed a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697405257


   The dir unlink script seems to be working fine, however (at least using a relative path):
   
       $ find . -name chip
       ./arch/arm/include/chip
       ./arch/arm/src/chip
       ./arch/z80/include/chip
       ./include/arch/chip
       
       $ tools/unlink.sh ./arch/z80/include/chip
       
       $ find . -name chip
       ./arch/arm/include/chip
       ./arch/arm/src/chip
       ./include/arch/chip
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-697887633


   @btashton @hartmannathan Should this be marked a blocker?  I had it tagged that way, but decided not.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] liuguo09 commented on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

liuguo09 commented on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-699592941


   Thanks for your explanation, I'm working on it and make PR ASAP once fixed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698580874


   >  But [b5dc837](https://github.com/apache/incubator-nuttx/commit/b5dc83748c0d28e4310655177419a51412ade07d) is the real culprit because it allows bad context setups into the user build. That could introduce wide-reaching, difficult to analyze problems.
   
   Actually I think I am mistaken about this:  that commit does not do the full context.  It only does dirlinks as far as I can tell.  If that is the case, then things are not so bad.  We just need to separate out a clean_links target to get rid of those links, just as clean_context was called previously.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1880: Cygwin directories not being cleaned

Posted by GitBox <gi...@apache.org>.

patacongo edited a comment on issue #1880:
URL: https://github.com/apache/incubator-nuttx/issues/1880#issuecomment-698512974


   There are multiple causes of the Cygwin CI build breakage.  This commit is also a factor:  bd656888f26c92e8832f0e76b395a5ece7704530  Although the other cited commits leave the system with a bad context setup, that would not have been noticed prior to this commit which changes the WINTOOL variable to the CONFIG_CYGWIN_WINTOOL Kconfig setting.  Previously WINTOOL would have been defined; bue CONFIG_CYGWIN_WINTOOL will not be defined (since it is the default and will not be in the defconfig).
   
   That is three commits that break the Cygwin CI build.  But b5dc837  is the real culprit because it allows bad context setups into the user build.  That could introduce wide-reaching, difficult to analyze problems.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org