You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/05/05 23:17:13 UTC

[GitHub] [arrow] westonpace commented on issue #35354: [Python][C++?] Dataset "right anti" join gives incorrect result with large_string columns (11.0.0)

westonpace commented on issue #35354:
URL: https://github.com/apache/arrow/issues/35354#issuecomment-1536892668

   I can confirm this with a unit test.  I suspect we are overflowing something but I don't see any asan or ubsan violations so it'll take a bit more digging:
   
   ```
   TEST(HashJoin, LargeString) {
     LargeStringBuilder builder;
     ASSERT_OK(builder.Reserve(1030));
     for (int i = 0; i < 1030; i++) {
       ASSERT_OK(builder.Append(std::to_string(i)));
     }
     ASSERT_OK_AND_ASSIGN(auto arr, builder.Finish());
     ExecBatch batch({arr}, 1030);
     std::vector<ExecBatch> batches = {batch};
   
     Declaration left{"exec_batch_source", ExecBatchSourceNodeOptions(
                                               schema({field("x", large_utf8())}), batches)};
     Declaration right{
         "exec_batch_source",
         ExecBatchSourceNodeOptions(schema({field("x", large_utf8())}), batches)};
   
     HashJoinNodeOptions join_opts(JoinType::RIGHT_ANTI, {"x"}, {"x"});
     Declaration join{"hashjoin", {left, right}, join_opts};
   
     ASSERT_OK_AND_ASSIGN(std::shared_ptr<Table> result, DeclarationToTable(join));
     std::cout << result->ToString() << std::endl;
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org