You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by co...@apache.org on 2024/10/04 21:38:40 UTC
(datafusion) branch main updated: Minor: Update string tests for strpos (#12739)
This is an automated email from the ASF dual-hosted git repository.
comphead pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new cf76aba36d Minor: Update string tests for strpos (#12739)
cf76aba36d is described below
commit cf76aba36d56f775a61bb434da5e8e3b07d9061d
Author: Andrew Lamb <an...@nerdnetworks.org>
AuthorDate: Fri Oct 4 17:38:36 2024 -0400
Minor: Update string tests for strpos (#12739)
---
.../test_files/string/large_string.slt | 17 ------------
.../sqllogictest/test_files/string/string.slt | 17 ------------
.../test_files/string/string_query.slt.part | 30 ++++++++++------------
.../sqllogictest/test_files/string/string_view.slt | 17 ------------
4 files changed, 14 insertions(+), 67 deletions(-)
diff --git a/datafusion/sqllogictest/test_files/string/large_string.slt b/datafusion/sqllogictest/test_files/string/large_string.slt
index 169c658e5a..af6d104e57 100644
--- a/datafusion/sqllogictest/test_files/string/large_string.slt
+++ b/datafusion/sqllogictest/test_files/string/large_string.slt
@@ -72,23 +72,6 @@ false false
false true
NULL NULL
-# TODO: move it back to `string_query.slt.part` after fixing the issue
-# see detail: https://github.com/apache/datafusion/issues/12670
-query IIIIII
-SELECT
- STRPOS(ascii_1, 'e'),
- STRPOS(ascii_1, 'ang'),
- STRPOS(ascii_1, NULL),
- STRPOS(unicode_1, 'и'),
- STRPOS(unicode_1, 'ион'),
- STRPOS(unicode_1, NULL)
-FROM test_basic_operator;
-----
-5 0 NULL 0 0 NULL
-7 3 NULL 0 0 NULL
-6 0 NULL 18 18 NULL
-NULL NULL NULL NULL NULL NULL
-
#
# common test for string-like functions and operators
#
diff --git a/datafusion/sqllogictest/test_files/string/string.slt b/datafusion/sqllogictest/test_files/string/string.slt
index f4e83966f7..f003e01ecd 100644
--- a/datafusion/sqllogictest/test_files/string/string.slt
+++ b/datafusion/sqllogictest/test_files/string/string.slt
@@ -63,23 +63,6 @@ Xiangpeng datafusion数据融合 false true false true
Raphael datafusionДатаФусион false false false false
NULL NULL NULL NULL NULL NULL
-# TODO: move it back to `string_query.slt.part` after fixing the issue
-# see detail: https://github.com/apache/datafusion/issues/12670
-query IIIIII
-SELECT
- STRPOS(ascii_1, 'e'),
- STRPOS(ascii_1, 'ang'),
- STRPOS(ascii_1, NULL),
- STRPOS(unicode_1, 'и'),
- STRPOS(unicode_1, 'ион'),
- STRPOS(unicode_1, NULL)
-FROM test_basic_operator;
-----
-5 0 NULL 0 0 NULL
-7 3 NULL 0 0 NULL
-6 0 NULL 18 18 NULL
-NULL NULL NULL NULL NULL NULL
-
#
# common test for string-like functions and operators
#
diff --git a/datafusion/sqllogictest/test_files/string/string_query.slt.part b/datafusion/sqllogictest/test_files/string/string_query.slt.part
index 3ba2b31bba..6a02296f5e 100644
--- a/datafusion/sqllogictest/test_files/string/string_query.slt.part
+++ b/datafusion/sqllogictest/test_files/string/string_query.slt.part
@@ -951,22 +951,20 @@ NULL NULL
# Test STRPOS
# --------------------------------------
-# TODO: DictionaryString does not support STRPOS. Enable this after fixing the issue
-# see issue: https://github.com/apache/datafusion/issues/12670
-#query IIIIII
-#SELECT
-# STRPOS(ascii_1, 'e'),
-# STRPOS(ascii_1, 'ang'),
-# STRPOS(ascii_1, NULL),
-# STRPOS(unicode_1, 'и'),
-# STRPOS(unicode_1, 'ион'),
-# STRPOS(unicode_1, NULL)
-#FROM test_basic_operator;
-#----
-#5 0 NULL 0 0 NULL
-#7 3 NULL 0 0 NULL
-#6 0 NULL 18 18 NULL
-#NULL NULL NULL NULL NULL NULL
+query IIIIII
+SELECT
+ STRPOS(ascii_1, 'e'),
+ STRPOS(ascii_1, 'ang'),
+ STRPOS(ascii_1, NULL),
+ STRPOS(unicode_1, 'и'),
+ STRPOS(unicode_1, 'ион'),
+ STRPOS(unicode_1, NULL)
+FROM test_basic_operator;
+----
+5 0 NULL 0 0 NULL
+7 3 NULL 0 0 NULL
+6 0 NULL 18 18 NULL
+NULL NULL NULL NULL NULL NULL
# --------------------------------------
# Test SUBSTR_INDEX
diff --git a/datafusion/sqllogictest/test_files/string/string_view.slt b/datafusion/sqllogictest/test_files/string/string_view.slt
index 4e7857ad80..e7b55c9c1c 100644
--- a/datafusion/sqllogictest/test_files/string/string_view.slt
+++ b/datafusion/sqllogictest/test_files/string/string_view.slt
@@ -50,23 +50,6 @@ false false
false true
NULL NULL
-# TODO: move it back to `string_query.slt.part` after fixing the issue
-# see detail: https://github.com/apache/datafusion/issues/12670
-query IIIIII
-SELECT
- STRPOS(ascii_1, 'e'),
- STRPOS(ascii_1, 'ang'),
- STRPOS(ascii_1, NULL),
- STRPOS(unicode_1, 'и'),
- STRPOS(unicode_1, 'ион'),
- STRPOS(unicode_1, NULL)
-FROM test_basic_operator;
-----
-5 0 NULL 0 0 NULL
-7 3 NULL 0 0 NULL
-6 0 NULL 18 18 NULL
-NULL NULL NULL NULL NULL NULL
-
#
# common test for string-like functions and operators
#
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org