You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/11 15:11:26 UTC
[GitHub] [incubator-tvm] siju-samuel opened a new pull request #5308:
[PYTORCH]Reduce_ops support added
siju-samuel opened a new pull request #5308: [PYTORCH]Reduce_ops support added
URL: https://github.com/apache/incubator-tvm/pull/5308
- Fixed reduce_sum
- Fixed reduce_prod
- argmin
- argmax
- std
- variance
@masahi please help to review and merge this PR. Thanks in advance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #5308:
[PYTORCH]Reduce_ops support added
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #5308: [PYTORCH]Reduce_ops support added
URL: https://github.com/apache/incubator-tvm/pull/5308#issuecomment-612654825
"Test code" doesn't mean code quality can be low. Add blank lines following established python style convention. Each functions are supposed to have two blank lines between them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] siju-samuel commented on issue #5308:
[PYTORCH]Reduce_ops support added
Posted by GitBox <gi...@apache.org>.
siju-samuel commented on issue #5308: [PYTORCH]Reduce_ops support added
URL: https://github.com/apache/incubator-tvm/pull/5308#issuecomment-612727798
@masahi Thanks a lot for the review. Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi edited a comment on issue #5308:
[PYTORCH]Reduce_ops support added
Posted by GitBox <gi...@apache.org>.
masahi edited a comment on issue #5308: [PYTORCH]Reduce_ops support added
URL: https://github.com/apache/incubator-tvm/pull/5308#issuecomment-612654825
"Test code" doesn't mean code quality can be low. Add blank lines following established python style convention. Each function or class definition are supposed to have two blank lines between them at the top level, and one line if defined inside a function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi merged pull request #5308:
[PYTORCH]Reduce_ops support added
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #5308: [PYTORCH]Reduce_ops support added
URL: https://github.com/apache/incubator-tvm/pull/5308
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #5308:
[PYTORCH]Reduce_ops support added
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #5308: [PYTORCH]Reduce_ops support added
URL: https://github.com/apache/incubator-tvm/pull/5308#issuecomment-612572466
@siju-samuel please fix the CI error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #5308:
[PYTORCH]Reduce_ops support added
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #5308: [PYTORCH]Reduce_ops support added
URL: https://github.com/apache/incubator-tvm/pull/5308#issuecomment-612773830
@siju-samuel sorry again, I just found a typo bug in our qnn test https://github.com/apache/incubator-tvm/blob/03cbf78e3e8cc910c5a9c95cd3fcafa19959644f/tests/python/frontend/pytorch/qnn_test.py#L399
Can you change `pt_result` there to `tvm_result`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #5308:
[PYTORCH]Reduce_ops support added
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #5308: [PYTORCH]Reduce_ops support added
URL: https://github.com/apache/incubator-tvm/pull/5308#issuecomment-612775491
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] siju-samuel commented on issue #5308:
[PYTORCH]Reduce_ops support added
Posted by GitBox <gi...@apache.org>.
siju-samuel commented on issue #5308: [PYTORCH]Reduce_ops support added
URL: https://github.com/apache/incubator-tvm/pull/5308#issuecomment-612774913
thanks @masahi, Done. Please have a look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #5308:
[PYTORCH]Reduce_ops support added
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #5308: [PYTORCH]Reduce_ops support added
URL: https://github.com/apache/incubator-tvm/pull/5308#issuecomment-612768751
@siju-samuel sorry my PR https://github.com/apache/incubator-tvm/pull/5306 was just merged and has conflict with this one. Can you rebase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services