You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/06 03:29:30 UTC

[GitHub] [flink] WeiZhong94 opened a new pull request #10770: [FLINK-15481][python] Add `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.

WeiZhong94 opened a new pull request #10770: [FLINK-15481][python] Add `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.
URL: https://github.com/apache/flink/pull/10770
 
 
   ## What is the purpose of the change
   
   *This pull request adds `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.*
   
   ## Brief change log
   
     - *Add `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.*
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10770: [FLINK-15481][python] Add `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10770: [FLINK-15481][python] Add `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.
URL: https://github.com/apache/flink/pull/10770#issuecomment-570993106
 
 
   <!--
   Meta data
   Hash:7644713d0bb78237bc2ed19c41ba1bed5f0fe863 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143190678 TriggerType:PUSH TriggerID:7644713d0bb78237bc2ed19c41ba1bed5f0fe863
   Hash:7644713d0bb78237bc2ed19c41ba1bed5f0fe863 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4107 TriggerType:PUSH TriggerID:7644713d0bb78237bc2ed19c41ba1bed5f0fe863
   -->
   ## CI report:
   
   * 7644713d0bb78237bc2ed19c41ba1bed5f0fe863 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143190678) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4107) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10770: [FLINK-15481][python] Add `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10770: [FLINK-15481][python] Add `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.
URL: https://github.com/apache/flink/pull/10770#issuecomment-570990080
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 7644713d0bb78237bc2ed19c41ba1bed5f0fe863 (Mon Jan 06 03:31:23 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 merged pull request #10770: [FLINK-15481][python] Add `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.

Posted by GitBox <gi...@apache.org>.
hequn8128 merged pull request #10770: [FLINK-15481][python] Add `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.
URL: https://github.com/apache/flink/pull/10770
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10770: [FLINK-15481][python] Add `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10770: [FLINK-15481][python] Add `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.
URL: https://github.com/apache/flink/pull/10770#issuecomment-570993106
 
 
   <!--
   Meta data
   Hash:7644713d0bb78237bc2ed19c41ba1bed5f0fe863 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:7644713d0bb78237bc2ed19c41ba1bed5f0fe863
   -->
   ## CI report:
   
   * 7644713d0bb78237bc2ed19c41ba1bed5f0fe863 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10770: [FLINK-15481][python] Add `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10770: [FLINK-15481][python] Add `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.
URL: https://github.com/apache/flink/pull/10770#issuecomment-570993106
 
 
   <!--
   Meta data
   Hash:7644713d0bb78237bc2ed19c41ba1bed5f0fe863 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143190678 TriggerType:PUSH TriggerID:7644713d0bb78237bc2ed19c41ba1bed5f0fe863
   Hash:7644713d0bb78237bc2ed19c41ba1bed5f0fe863 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4107 TriggerType:PUSH TriggerID:7644713d0bb78237bc2ed19c41ba1bed5f0fe863
   -->
   ## CI report:
   
   * 7644713d0bb78237bc2ed19c41ba1bed5f0fe863 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143190678) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4107) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10770: [FLINK-15481][python] Add `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10770: [FLINK-15481][python] Add `list[str]` to the type hint of the parameter "schema" in `TableEnvironment#from_elements`.
URL: https://github.com/apache/flink/pull/10770#issuecomment-570993106
 
 
   <!--
   Meta data
   Hash:7644713d0bb78237bc2ed19c41ba1bed5f0fe863 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143190678 TriggerType:PUSH TriggerID:7644713d0bb78237bc2ed19c41ba1bed5f0fe863
   Hash:7644713d0bb78237bc2ed19c41ba1bed5f0fe863 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4107 TriggerType:PUSH TriggerID:7644713d0bb78237bc2ed19c41ba1bed5f0fe863
   -->
   ## CI report:
   
   * 7644713d0bb78237bc2ed19c41ba1bed5f0fe863 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143190678) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4107) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services