[GitHub] [spark] HyukjinKwon commented on a change in pull request #31636: [SPARK-34520][CORE] Remove unused SecurityManager references

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #31636:
URL: https://github.com/apache/spark/pull/31636#discussion_r581908210



##########
File path: core/src/main/scala/org/apache/spark/metrics/sink/PrometheusServlet.scala
##########
@@ -23,23 +23,19 @@ import javax.servlet.http.HttpServletRequest
 import com.codahale.metrics.MetricRegistry
 import org.eclipse.jetty.servlet.ServletContextHandler
 
-import org.apache.spark.{SecurityManager, SparkConf}
-import org.apache.spark.annotation.Experimental
+import org.apache.spark.SparkConf
 import org.apache.spark.ui.JettyUtils._
 
 /**
- * :: Experimental ::

Review comment:
       @dongjoon-hyun, would you mind double checking this? I am reading https://github.com/apache/spark/commit/b80309bdb4d26556bd3da6a61cac464cdbdd1fe1#. Maybe we could just remove `Experimental` here. Seems like the endpoints are documented as experimental properly as intended, and this `PrometheusServlet` class seems not an API.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org