[GitHub] [skywalking-python] tom-pytel commented on a change in pull request #148: Remove the temporary gRPC log channel

[GitBox <gi...@apache.org>]

tom-pytel commented on a change in pull request #148:
URL: https://github.com/apache/skywalking-python/pull/148#discussion_r685330220



##########
File path: skywalking/agent/protocol/__init__.py
##########
@@ -35,5 +35,8 @@ def heartbeat(self):
     def report(self, queue: Queue, block: bool = True):
         raise NotImplementedError()
 
+    def report_log(self, queue: Queue, block: bool = True):
+        raise NotImplementedError()

Review comment:
       If it is documented that log reporting is not currently implemented for these protocols then it is the responsibility of the user to not enable log reporting if not using grpc, no?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org