[jira] [Work logged] (BEAM-12464) Change ProtoSchemaTranslator beam schema creation to match the order for protobufs containing Oneof fields

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-12464?focusedWorklogId=663229&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663229 ]

ASF GitHub Bot logged work on BEAM-12464:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Oct/21 01:54
            Start Date: 10/Oct/21 01:54
    Worklog Time Spent: 10m 
      Work Description: maduris commented on pull request #14974:
URL: https://github.com/apache/beam/pull/14974#issuecomment-939391046


   hi @reubenvanammers,
   
   Glad you are already looking to the same issue we are facing.
   
   I believe the convert function needs to be also updated to use the identifier number instead of the enum index on line
   oneOfConvert has indices using the identifiers from proto definition where oneOf only has enum value.
   
   https://github.com/apache/beam/blob/master/sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoDynamicMessageSchema.java#L731
   
   Something like?
   
   `        @Override
           void setOnProtoMessage(Message.Builder message, OneOfType.Value oneOf) {
               int caseIndex = oneOf.getCaseType().getValue();
               int convertIndex =
                   logicalType.getCaseEnumType().valueOf(logicalType.getCaseEnumType().getValues().get(caseIndex)).getValue();
               oneOfConvert.get(convertIndex).setOnProtoMessage(message, oneOf.getValue());
           }`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 663229)
    Time Spent: 4h 20m  (was: 4h 10m)

> Change ProtoSchemaTranslator beam schema creation to match the order for protobufs containing Oneof fields
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-12464
>                 URL: https://issues.apache.org/jira/browse/BEAM-12464
>             Project: Beam
>          Issue Type: Improvement
>          Components: extensions-java-protobuf
>            Reporter: Reuben van Ammers
>            Priority: P3
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> Currently, when ProtoSchemaTranslator creates the beam schema from a protobuf definition it always puts the Oneofs at the start of the beam schema due to Oneofs being created from the code first. This means that the order of the fields doesn't match the order of the protobuf defintion. As the schema generation is used when converting from beam rows to protobufs, it additionally means that it is impossible to convert from a beam row where the oneof fields are not the first fields in the beamrow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)