You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/11/16 13:17:34 UTC
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request
#540: [IOTDB-299] merge ChunkBuffer into ChunkWriterImpl
qiaojialin commented on a change in pull request #540: [IOTDB-299] merge ChunkBuffer into ChunkWriterImpl
URL: https://github.com/apache/incubator-iotdb/pull/540#discussion_r347091213
##########
File path: tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/ChunkWriterImpl.java
##########
@@ -327,21 +346,21 @@ private void writePage() {
@Override
public void writeToFileWriter(TsFileIOWriter tsfileWriter) throws IOException {
sealCurrentPage();
- chunkBuffer.writeAllPagesOfSeriesToTsFile(tsfileWriter, chunkStatistics);
- chunkBuffer.reset();
+ this.writeAllPagesOfSeriesToTsFile(tsfileWriter, chunkStatistics);
Review comment:
this is usually not needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services