[GitHub] [iceberg] wangyinsheng commented on pull request #7144: Core: Add metrics reporter for serializable table

["wangyinsheng (via GitHub)" <gi...@apache.org>]

wangyinsheng commented on PR #7144:
URL: https://github.com/apache/iceberg/pull/7144#issuecomment-1586785170

   > > @nastra, where are we with the fix for serialization here?
   > 
   > @rdblue I haven't heard back from @wangyinsheng after [my comment above ](https://github.com/apache/iceberg/pull/7144#issuecomment-1519866237), so I've opened #7370 a while ago for initial experimentation and then updated it to fix the serialization issue.
   
   @nastra @rdblue Sorry，I am working on other things for a while.  But I am still keep my opinion,  I think the `SerializableTable` is the best place to handle the `lazily initialization` stuff for `MetricsReporter`, we should not just make `MetricsReporter` serializable, which will throw the `lazily initialization` stuff to any implemention class of `MetricsReporter`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org