[GitHub] [iotdb] LebronAl commented on a change in pull request #2483: Add authentication in the node tool and modify the node tools doc

[GitBox <gi...@apache.org>]

LebronAl commented on a change in pull request #2483:
URL: https://github.com/apache/iotdb/pull/2483#discussion_r556989640



##########
File path: docs/zh/UserGuide/System Tools/NodeTool.md
##########
@@ -25,12 +25,17 @@ IoTDB集群版为您提供了NodeTool Shell工具用于监控指定集群的工
 
 下面具体介绍每个指令的使用方式及示例，其中$IOTDB_CLUSTER_HOME表示IoTDB分布式的安装目录所在路径。
 
+# 前提条件
+使用NodeTool需要开启JMX服务，具体请参考[JMX Tool](JMX Tool.md)
+
 # 使用说明
 
 ## 运行方式
+
 NodeTool Shell工具启动脚本位于$IOTDB_CLUSTER_HOME/sbin文件夹下，启动时可以指定集群运行的IP和PORT。
+其中IP为您期望连接的节点的IP，PORT为IoTDB集群启动时指定的JMX服务端口号，分别默认为`127.0.0.1`和`31999`。
 
-其中IP为您期望连接的节点的IP，PORT为IoTDB集群启动时指定的JMX服务端口号，分别默认为127.0.0.1和31999。
+对于开启了JMX鉴权服务的，启动时候需要指定JMX服务的用户名和密码，默认分别为`iotdb`和`passw!d`

Review comment:
       same as above

##########
File path: docs/UserGuide/System Tools/NodeTool.md
##########
@@ -34,7 +37,10 @@ you can specify the IP address and port of the cluster during startup.
 IP is the IP (or hostname) of the node that you expect to connect to,
 and port is the JMX service port specified when the IoTDB cluster is started.
 
-The default values are 127.0.0.1 and 31999, respectively.
+The default values are `127.0.0.1` and `31999`, respectively.
+
+When JMX authentication service is enabled, the user name and password of JMX service should be specified. 

Review comment:
       These two lines should be put after the next two lines? And it's better to point out how to change authentication parameters, such as -u,-pw.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org