You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "yf13 (via GitHub)" <gi...@apache.org> on 2023/12/15 05:19:14 UTC
[PR] fix etctmp.c and etctmp/ leakage [nuttx]
yf13 opened a new pull request, #11401:
URL: https://github.com/apache/nuttx/pull/11401
## Summary
etctmp.c and etctmp/ folder leaks out after a build. This fix adds cleaning commands after use.
## Impact
none
## Testing
checked with canmv230/ksh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix etctmp.c and etctmp/ leakage [nuttx]
Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on code in PR #11401:
URL: https://github.com/apache/nuttx/pull/11401#discussion_r1428728141
##########
boards/Board.mk:
##########
@@ -87,6 +87,7 @@ $(CXXOBJS) $(LINKOBJS): %$(OBJEXT): %.cxx
libboard$(LIBEXT): $(OBJS) $(CXXOBJS)
$(call ARCHIVE, $@, $(OBJS) $(CXXOBJS))
+ $(Q) rm -f $(ETCSRC)
Review Comment:
okay, then I will include it in the boards/ sub-folder I am adding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix etctmp.c and etctmp/ leakage [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #11401:
URL: https://github.com/apache/nuttx/pull/11401#discussion_r1428719216
##########
boards/Board.mk:
##########
@@ -87,6 +87,7 @@ $(CXXOBJS) $(LINKOBJS): %$(OBJEXT): %.cxx
libboard$(LIBEXT): $(OBJS) $(CXXOBJS)
$(call ARCHIVE, $@, $(OBJS) $(CXXOBJS))
+ $(Q) rm -f $(ETCSRC)
Review Comment:
The correct fix is added etctmp* to .gitignored like this:
https://github.com/apache/nuttx/blob/master/boards/sim/sim/sim/src/.gitignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix etctmp.c and etctmp/ leakage [nuttx]
Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 closed pull request #11401: fix etctmp.c and etctmp/ leakage
URL: https://github.com/apache/nuttx/pull/11401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix etctmp.c and etctmp/ leakage [nuttx]
Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on PR #11401:
URL: https://github.com/apache/nuttx/pull/11401#issuecomment-1858760353
current behavior is by design thus canceling this request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix etctmp.c and etctmp/ leakage [nuttx]
Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on code in PR #11401:
URL: https://github.com/apache/nuttx/pull/11401#discussion_r1428692786
##########
boards/Board.mk:
##########
@@ -87,6 +87,7 @@ $(CXXOBJS) $(LINKOBJS): %$(OBJEXT): %.cxx
libboard$(LIBEXT): $(OBJS) $(CXXOBJS)
$(call ARCHIVE, $@, $(OBJS) $(CXXOBJS))
+ $(Q) rm -f $(ETCSRC)
Review Comment:
@xiaoxiang781216
I saw these files shows up as warnings in one of my PR checks. Thus I was wondering if they should be cleaned after use.
If keeping those generated files is more useful, we don't have to use this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix etctmp.c and etctmp/ leakage [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #11401:
URL: https://github.com/apache/nuttx/pull/11401#discussion_r1428670725
##########
boards/Board.mk:
##########
@@ -87,6 +87,7 @@ $(CXXOBJS) $(LINKOBJS): %$(OBJEXT): %.cxx
libboard$(LIBEXT): $(OBJS) $(CXXOBJS)
$(call ARCHIVE, $@, $(OBJS) $(CXXOBJS))
+ $(Q) rm -f $(ETCSRC)
Review Comment:
`ETCSRC` is removed in clean target, why need remove it here?
##########
boards/Board.mk:
##########
@@ -38,7 +38,7 @@ $(ETCSRC): $(addprefix $(BOARD_DIR)$(DELIM)src$(DELIM),$(RCRAWS)) $(RCOBJS)
$(Q) genromfs -f romfs.img -d $(ETCDIR)$(DELIM)$(CONFIG_NSH_ROMFSMOUNTPT) -V "NSHInitVol"
$(Q) echo "#include <nuttx/compiler.h>" > $@
$(Q) xxd -i romfs.img | sed -e "s/^unsigned char/const unsigned char aligned_data(4)/g" >> $@
- $(Q) rm romfs.img
+ $(Q) rm -rf romfs.img $(ETCDIR)$(DELIM)
Review Comment:
the change will make romfs.img generate in each make even all content under etc/ isn't change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org