You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/09/10 09:03:33 UTC
[jira] Created: (HBASE-2980) Refactor HRegionServer command line
parsing
Refactor HRegionServer command line parsing
-------------------------------------------
Key: HBASE-2980
URL: https://issues.apache.org/jira/browse/HBASE-2980
Project: HBase
Issue Type: Task
Components: regionserver
Affects Versions: 0.90.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Minor
Fix For: 0.90.0
Similar to HBASE-2977, refactor the command line parsing logic out of the HRegionServer class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2980) Refactor HRegionServer command line
parsing
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908923#action_12908923 ]
HBase Review Board commented on HBASE-2980:
-------------------------------------------
Message from: stack@duboce.net
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/#review1165
-----------------------------------------------------------
Ship it!
+1 I took a look at ServerCommandLine. Looks fine.
- stack
> Refactor HRegionServer command line parsing
> -------------------------------------------
>
> Key: HBASE-2980
> URL: https://issues.apache.org/jira/browse/HBASE-2980
> Project: HBase
> Issue Type: Task
> Components: regionserver
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.90.0
>
>
> Similar to HBASE-2977, refactor the command line parsing logic out of the HRegionServer class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-2980) Refactor HRegionServer command line
parsing
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved HBASE-2980.
--------------------------------
Hadoop Flags: [Reviewed]
Resolution: Fixed
> Refactor HRegionServer command line parsing
> -------------------------------------------
>
> Key: HBASE-2980
> URL: https://issues.apache.org/jira/browse/HBASE-2980
> Project: HBase
> Issue Type: Task
> Components: regionserver
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.90.0
>
>
> Similar to HBASE-2977, refactor the command line parsing logic out of the HRegionServer class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2980) Refactor HRegionServer command line
parsing
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908921#action_12908921 ]
HBase Review Board commented on HBASE-2980:
-------------------------------------------
Message from: "Todd Lipcon" <to...@cloudera.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/
-----------------------------------------------------------
(Updated 2010-09-13 11:29:19.499500)
Review request for hbase, stack and Jonathan Gray.
Changes
-------
Updated diff, renames DaemonCommandLine to ServerCommandLine. Also I realized I forgot to include DaemonCommandLine in the diff last time, so should probably have someone look that over.
Summary
-------
Same as HBASE-2977 but from the master side
This addresses bug HBASE-2980.
http://issues.apache.org/jira/browse/HBASE-2980
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 792fb3e
src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java 6421808
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1e046f9
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServerCommandLine.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/util/ServerCommandLine.java PRE-CREATION
src/test/java/org/apache/hadoop/hbase/master/OOMEHMaster.java b51e6ab
src/test/java/org/apache/hadoop/hbase/regionserver/OOMERegionServer.java c591632
Diff: http://review.cloudera.org/r/812/diff
Testing
-------
Started a region server, also checked usage info for a bad param.
Thanks,
Todd
> Refactor HRegionServer command line parsing
> -------------------------------------------
>
> Key: HBASE-2980
> URL: https://issues.apache.org/jira/browse/HBASE-2980
> Project: HBase
> Issue Type: Task
> Components: regionserver
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.90.0
>
>
> Similar to HBASE-2977, refactor the command line parsing logic out of the HRegionServer class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2980) Refactor HRegionServer command line
parsing
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908871#action_12908871 ]
HBase Review Board commented on HBASE-2980:
-------------------------------------------
Message from: "Todd Lipcon" <to...@cloudera.com>
bq. On 2010-09-10 08:42:41, stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java, line 48
bq. > <http://review.cloudera.org/r/812/diff/1/?file=11389#file11389line48>
bq. >
bq. > Daemon is a good name but maybe use the not so good 'ServerCommandLine' so it aligns w/ the new Server Interface we extracted from Master and RS
bq. >
bq. > Or we could change the 'Server' Interface name to Daemon?
Will change to ServerCommandLine like you suggested. Want to re-review the change or shall I just commit when fixed?
- Todd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/#review1151
-----------------------------------------------------------
> Refactor HRegionServer command line parsing
> -------------------------------------------
>
> Key: HBASE-2980
> URL: https://issues.apache.org/jira/browse/HBASE-2980
> Project: HBase
> Issue Type: Task
> Components: regionserver
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.90.0
>
>
> Similar to HBASE-2977, refactor the command line parsing logic out of the HRegionServer class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2980) Refactor HRegionServer command line
parsing
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908920#action_12908920 ]
HBase Review Board commented on HBASE-2980:
-------------------------------------------
Message from: stack@duboce.net
bq. On 2010-09-10 08:42:41, stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java, line 48
bq. > <http://review.cloudera.org/r/812/diff/1/?file=11389#file11389line48>
bq. >
bq. > Daemon is a good name but maybe use the not so good 'ServerCommandLine' so it aligns w/ the new Server Interface we extracted from Master and RS
bq. >
bq. > Or we could change the 'Server' Interface name to Daemon?
bq.
bq. Todd Lipcon wrote:
bq. Will change to ServerCommandLine like you suggested. Want to re-review the change or shall I just commit when fixed?
Just commit. No need of re-review. Thanks Todd.
- stack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/#review1151
-----------------------------------------------------------
> Refactor HRegionServer command line parsing
> -------------------------------------------
>
> Key: HBASE-2980
> URL: https://issues.apache.org/jira/browse/HBASE-2980
> Project: HBase
> Issue Type: Task
> Components: regionserver
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.90.0
>
>
> Similar to HBASE-2977, refactor the command line parsing logic out of the HRegionServer class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2980) Refactor HRegionServer command line
parsing
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908061#action_12908061 ]
HBase Review Board commented on HBASE-2980:
-------------------------------------------
Message from: stack@duboce.net
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/#review1151
-----------------------------------------------------------
Ship it!
+1
src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
<http://review.cloudera.org/r/812/#comment3968>
Daemon is a good name but maybe use the not so good 'ServerCommandLine' so it aligns w/ the new Server Interface we extracted from Master and RS
Or we could change the 'Server' Interface name to Daemon?
- stack
> Refactor HRegionServer command line parsing
> -------------------------------------------
>
> Key: HBASE-2980
> URL: https://issues.apache.org/jira/browse/HBASE-2980
> Project: HBase
> Issue Type: Task
> Components: regionserver
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.90.0
>
>
> Similar to HBASE-2977, refactor the command line parsing logic out of the HRegionServer class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2980) Refactor HRegionServer command line
parsing
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907919#action_12907919 ]
HBase Review Board commented on HBASE-2980:
-------------------------------------------
Message from: "Todd Lipcon" <to...@cloudera.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/
-----------------------------------------------------------
Review request for hbase, stack and Jonathan Gray.
Summary
-------
Same as HBASE-2977 but from the master side
This addresses bug HBASE-2980.
http://issues.apache.org/jira/browse/HBASE-2980
Diffs
-----
src/main/java/org/apache/hadoop/hbase/master/HMaster.java adc6292
src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java 6421808
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1e046f9
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServerCommandLine.java PRE-CREATION
src/test/java/org/apache/hadoop/hbase/master/OOMEHMaster.java b51e6ab
src/test/java/org/apache/hadoop/hbase/regionserver/OOMERegionServer.java c591632
Diff: http://review.cloudera.org/r/812/diff
Testing
-------
Started a region server, also checked usage info for a bad param.
Thanks,
Todd
> Refactor HRegionServer command line parsing
> -------------------------------------------
>
> Key: HBASE-2980
> URL: https://issues.apache.org/jira/browse/HBASE-2980
> Project: HBase
> Issue Type: Task
> Components: regionserver
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.90.0
>
>
> Similar to HBASE-2977, refactor the command line parsing logic out of the HRegionServer class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.