You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/12 04:54:21 UTC
[jira] [Commented] (BEAM-742) Move trigger state machines to
runners-core, convert triggers to AST
[ https://issues.apache.org/jira/browse/BEAM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567584#comment-15567584 ]
ASF GitHub Bot commented on BEAM-742:
-------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1083
[BEAM-742] Replicate triggers to runners-core (migration step towards conversion to AST)
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam TriggerReactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1083.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1083
----
commit 241566d0e47d972b5afa7a0ab43b856dddb60ed6
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-06-24T03:05:27Z
Move triggers to runners-core
This commit is effectively a "git hint" that all the files
in runners-core are moved from prior files. The moved files
will be replaced.
commit 4465a589af483db3bbf0ec1c90517fc57a67631a
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-06-24T03:31:10Z
Rename trigger reactors
commit 3a79b875bb28f659e90e9aae8e844022ea3546dd
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-10-12T04:35:02Z
Restore prior trigger files, for temporary compatibility
----
> Move trigger state machines to runners-core, convert triggers to AST
> --------------------------------------------------------------------
>
> Key: BEAM-742
> URL: https://issues.apache.org/jira/browse/BEAM-742
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core, sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)