[GitHub] [cordova-android] breautek commented on a change in pull request #792: [MAJOR] Gradle upgrade from 4.10.3 to 6.x

[GitBox <gi...@apache.org>]

breautek commented on a change in pull request #792: [MAJOR] Gradle upgrade from 4.10.3 to 6.x
URL: https://github.com/apache/cordova-android/pull/792#discussion_r363558915
 
 

 ##########
 File path: bin/templates/project/app/build.gradle
 ##########
 @@ -40,7 +40,7 @@ allprojects {
 }
 
 task wrapper(type: Wrapper) {
-    gradleVersion = '4.10.3'
+    gradleVersion = '6.0'
 
 Review comment:
   Note to myself mainly but before I commit to 6.x, I need to double check things still works fine in android studio, because according to the [docs](https://developer.android.com/studio/releases/gradle-plugin) the latest gradle plugin only supports up to 5.6.4.
   
   Been awhile since I looked at this but in my testing I probably only used the cordova command line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org