You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/10/11 09:48:09 UTC

Review Request: Added ports (31000-32000) as default resouces.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7540/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Description
-------

See summary.


Diffs
-----

  src/slave/slave.cpp 752cc71771ec84632d1c92c1718a1f7437e96298 

Diff: https://reviews.apache.org/r/7540/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request: Added ports (31000-32000) as default resouces.

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On Oct. 11, 2012, 10:10 p.m., Ben Mahler wrote:
> > Curious, what was the reason behind this?

It's the right thing to do. There are a lot of old services that require specifying ports (that don't use ephemeral ports by default) and to support those we need to provide a port range.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7540/#review12358
-----------------------------------------------------------


On Oct. 11, 2012, 7:48 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7540/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 7:48 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 752cc71771ec84632d1c92c1718a1f7437e96298 
> 
> Diff: https://reviews.apache.org/r/7540/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request: Added ports (31000-32000) as default resouces.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7540/#review12358
-----------------------------------------------------------

Ship it!


Curious, what was the reason behind this?

- Ben Mahler


On Oct. 11, 2012, 7:48 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7540/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 7:48 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 752cc71771ec84632d1c92c1718a1f7437e96298 
> 
> Diff: https://reviews.apache.org/r/7540/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>