[GitHub] rabbah commented on a change in pull request #243: parameterize host name and edge host

[gi...@git.apache.org]

rabbah commented on a change in pull request #243: parameterize host name and edge host
URL: https://github.com/apache/incubator-openwhisk-catalog/pull/243#discussion_r141670861
 
 

 ##########
 File path: packages/installCatalog.sh
 ##########
 @@ -8,11 +8,11 @@
 SCRIPTDIR="$(cd $(dirname "$0")/ && pwd)"
 OPENWHISK_HOME=${OPENWHISK_HOME:-$SCRIPTDIR/../../openwhisk}
 
-source "$SCRIPTDIR/validateParameter.sh" $1 $2 $3
-: ${WHISK_SYSTEM_AUTH:?"WHISK_SYSTEM_AUTH is not configured. Please input the correctly parameter: CATALOG_AUTH_KEY"}
-: ${WHISK_API_HOST:?"WHISK_API_HOST is not configured. Please input the correctly parameter: API_HOST"}
-: ${WHISK_CLI_PATH:?"WHISK_CLI_PATH is not configured. Please input the correctly parameter: cli_path"}
-
+source "$SCRIPTDIR/validateParameter.sh" $1 $2 $3 $4 $5
+: ${WHISK_SYSTEM_AUTH:?"WHISK_SYSTEM_AUTH is not configured. Please input the correct parameter: CATALOG_AUTH_KEY"}
+: ${WHISK_EDGE_HOST:?"WHISK_EDGE_HOST is not configured. Please input the correct parameter: API_HOST"}
 
 Review comment:
   i think you want to use the api host not the edge host.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services