You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Rainer Jung <ra...@kippdata.de> on 2019/08/06 13:55:23 UTC
Re: svn commit: r1854603 - in /apr/apr-util/branches/1.7.x:
build/apu-conf.m4 build/xml.m4 configure.in include/apu.h.in include/apu.hw
include/apu.hwc xml/NWGNUmakefile xml/apr_xml.c xml/apr_xml_expat.c
xml/apr_xml_internal.h xml/apr_xml_libxml2.c
Just a reminder, that APR-UTIL 1.7.x still doesn't compile due to the
wrong handling of INCLUDES.
Am 30.03.2019 um 14:31 schrieb Rainer Jung:
> Hi Nick,
>
> Am 27.03.2019 um 23:42 schrieb Nick Kew:
>>
>>
>>> On 27 Mar 2019, at 17:55, Rainer Jung <ra...@kippdata.de> wrote:
>>>
>>> This breaks 1.7 apu compilation using non-system expat for me. The
>>> expat detection sets INCLUDES but during compilation INCLUDES isn't
>>> used anywhere, so expat.h can't be found.
>>
>> OK, I need to return to that. Thanks for the reminder!
>>
>> Does trunk compile for you in the same circumstances?
>> This is supposed to be a backport!
>
> Trunk is APR which adds INCLUDES to EXTRA_INCLUDES and uses those during
> build. APU doesn't use EXTRA_INCLUDES anywhere but uses the
> APRUTIL_PRIV_INCLUDES and APRUTIL_INCLUDES variables, none of which the
> expat flags gets added to. dbd seems to use APRUTIL_PRIV_INCLUDES, all
> other dependencies seem to use APRUTIL_INCLUDES ...
>
> Regards,
>
> Rainer
Re: svn commit: r1854603 - in /apr/apr-util/branches/1.7.x:
build/apu-conf.m4 build/xml.m4 configure.in include/apu.h.in include/apu.hw
include/apu.hwc xml/NWGNUmakefile xml/apr_xml.c xml/apr_xml_expat.c
xml/apr_xml_internal.h xml/apr_xml_libxml2.c
Posted by Nick Kew <ni...@apache.org>.
> On 25 Jul 2020, at 10:10, Graham Leggett <mi...@sharp.fm> wrote:
>
> On 24 Jul 2020, at 17:03, Nick Kew <ni...@apache.org> wrote:
>
>>> Another ping on this one - the apr-util 1.7 build is still broken.
>>
>> Whoops! I'd completely forgotten that.
>>
>> Thanks for the partial patch. Do you want to commit it?
>
> I’ve just committed http://svn.apache.org/viewvc?rev=1880286&view=rev and http://svn.apache.org/viewvc?rev=1880287&view=rev - it Works For Me(TM) on MacOS and CentOS8, can you give it a try?
Thanks. All works cleanly for me on both my platforms (Debian and
MacOSX/homebrew) with either XML parser option.
I note that it's building both apr_xml_expat.o and apr_xml_libxml2.o,
but that the one not selected is empty. Are we bothered by that?
An alternative would be to #include the expat and libxml2 source
files into apr_xml.c, with the existing #ifdefs to select which gets used.
--
Nick Kew
Re: svn commit: r1854603 - in /apr/apr-util/branches/1.7.x:
build/apu-conf.m4 build/xml.m4 configure.in include/apu.h.in include/apu.hw
include/apu.hwc xml/NWGNUmakefile xml/apr_xml.c xml/apr_xml_expat.c
xml/apr_xml_internal.h xml/apr_xml_libxml2.c
Posted by Graham Leggett <mi...@sharp.fm>.
On 24 Jul 2020, at 17:03, Nick Kew <ni...@apache.org> wrote:
>> Another ping on this one - the apr-util 1.7 build is still broken.
>
> Whoops! I'd completely forgotten that.
>
> Thanks for the partial patch. Do you want to commit it?
I’ve just committed http://svn.apache.org/viewvc?rev=1880286&view=rev <http://svn.apache.org/viewvc?rev=1880286&view=rev> and http://svn.apache.org/viewvc?rev=1880287&view=rev <http://svn.apache.org/viewvc?rev=1880287&view=rev> - it Works For Me(TM) on MacOS and CentOS8, can you give it a try?
Regards,
Graham
—
Re: svn commit: r1854603 - in /apr/apr-util/branches/1.7.x:
build/apu-conf.m4 build/xml.m4 configure.in include/apu.h.in include/apu.hw
include/apu.hwc xml/NWGNUmakefile xml/apr_xml.c xml/apr_xml_expat.c
xml/apr_xml_internal.h xml/apr_xml_libxml2.c
Posted by Nick Kew <ni...@apache.org>.
On Fri, 24 Jul 2020 14:11:10 +0200
Graham Leggett <mi...@sharp.fm> wrote:
> On 06 Aug 2019, at 15:55, Rainer Jung <ra...@kippdata.de> wrote:
>
> > Just a reminder, that APR-UTIL 1.7.x still doesn't compile due to
> > the wrong handling of INCLUDES.
>
> Another ping on this one - the apr-util 1.7 build is still broken.
Whoops! I'd completely forgotten that.
Thanks for the partial patch. Do you want to commit it?
--
Nick Kew
Re: svn commit: r1854603 - in /apr/apr-util/branches/1.7.x:
build/apu-conf.m4 build/xml.m4 configure.in include/apu.h.in include/apu.hw
include/apu.hwc xml/NWGNUmakefile xml/apr_xml.c xml/apr_xml_expat.c
xml/apr_xml_internal.h xml/apr_xml_libxml2.c
Posted by Graham Leggett <mi...@sharp.fm>.
On 06 Aug 2019, at 15:55, Rainer Jung <ra...@kippdata.de> wrote:
> Just a reminder, that APR-UTIL 1.7.x still doesn't compile due to the wrong handling of INCLUDES.
Another ping on this one - the apr-util 1.7 build is still broken.
Tried a number of options to fix it, the includes sort of works if you try the patch below, but the LIBS are very broken. For some reason autoconf tries to bind to both the expat and libxml2 libs, but then ultimately includes neither of them.
Index: build/xml.m4
===================================================================
--- build/xml.m4 (revision 1880261)
+++ build/xml.m4 (working copy)
@@ -148,12 +148,12 @@
[ --with-libxml2=DIR specify libxml2 location], [
if test "$withval" = "yes"; then
apu_try_libxml2=1
- APR_ADDTO(INCLUDES, [-I/usr/include/libxml2])
+ APR_ADDTO(APRUTIL_INCLUDES, [-I/usr/include/libxml2])
elif test "$withval" != "no"; then
apu_try_libxml2=1
- APR_ADDTO(INCLUDES, [-I$withval/include/libxml2])
+ APR_ADDTO(APRUTIL_INCLUDES, [-I$withval/include/libxml2])
if test "$withval" != "/usr"; then
- APR_ADDTO(LDFLAGS, [-L$withval/lib])
+ APR_ADDTO(APRUTIL_LDFLAGS, [-L$withval/lib])
fi
fi
if test ${apu_try_libxml2} = "1" ; then
Regards,
Graham
—