You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/11/19 13:51:02 UTC

[GitHub] [hadoop] sodonnel commented on pull request #3630: HADOOP-17995. Stale record should be remove when DataNodePeerMetrics#dumpSendPacketDownstreamAvgInfoAsJson

sodonnel commented on pull request #3630:
URL: https://github.com/apache/hadoop/pull/3630#issuecomment-974089664


   This change has introduced a findbugs warning on trunk, which was in the build above:
   
   ```
   <a name="Warnings_MT_CORRECTNESS">Multithreaded correctness Warnings</a>
        
   code | Warning
   -- | --
   IS | Inconsistent synchronization of org.apache.hadoop.metrics2.lib.MutableRollingAverages.recordValidityMs; locked 66% of time
   ```
   
   I wonder if the snapshot method needs synchronised to avoid this? We cannot make `recordValidityMs` final is it can be changed by the tests, but we need to fix it somehow to clear the spotbugs warning which is now present in all PRs since this one.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org