You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by vi...@apache.org on 2020/09/11 12:07:05 UTC
[incubator-superset] 07/34: Remove incorrect comment (#10652)
This is an automated email from the ASF dual-hosted git repository.
villebro pushed a commit to branch 0.38
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
commit e288fb8bb318d8fbfff574b289efd914bec1ca27
Author: Will Barrett <wi...@preset.io>
AuthorDate: Mon Aug 24 10:40:36 2020 -0700
Remove incorrect comment (#10652)
---
superset/charts/api.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/superset/charts/api.py b/superset/charts/api.py
index d913801..4fd70f4 100644
--- a/superset/charts/api.py
+++ b/superset/charts/api.py
@@ -565,7 +565,7 @@ class ChartRestApi(BaseSupersetModelRestApi):
}
cache_chart_thumbnail.delay(**kwargs)
return self.response(
- 202, cache_key=cache_key, chart_url=chart_url, image_url=image_url,
+ 202, cache_key=cache_key, chart_url=chart_url, image_url=image_url
)
return trigger_celery()
@@ -614,8 +614,6 @@ class ChartRestApi(BaseSupersetModelRestApi):
if not chart:
return self.response_404()
- # TODO make sure the user has access to the chart
-
# fetch the chart screenshot using the current user and cache if set
img = ChartScreenshot.get_from_cache_key(thumbnail_cache, digest)
if img: