You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cbiow <gi...@git.apache.org> on 2015/04/30 20:44:48 UTC
[GitHub] spark pull request: Limit help option regex
GitHub user cbiow opened a pull request:
https://github.com/apache/spark/pull/5816
Limit help option regex
Added word-boundary delimiters so that embedded text such as "-h" within command line options and values doesn't trigger the usage script and exit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cbiow/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5816.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5816
----
commit 36b3726a9a1af4c48b7321484e176715f0678329
Author: Chris Biow <ch...@10gen.com>
Date: 2015-04-30T18:29:54Z
Limit help option regex
Added word-boundary delimiters so that embedded text such as "-h" within command line options don't trigger the usage script and exit.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Limit help option regex
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5816#issuecomment-97972207
Usually we want a JIRA for changes, but this is probably below the threshold. I don't know Windows shell syntax, but trust your judgment. So this definitely only matches a command line containing `--help` or `-h` as independent args and nothing else? sounds good. CC @tsudukim as someone who's also looked at a lot of the Windows batch scripts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Limit help option regex
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5816#issuecomment-97919567
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org