You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 06:04:41 UTC

[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #12930: ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows

jorisvandenbossche commented on code in PR #12930:
URL: https://github.com/apache/arrow/pull/12930#discussion_r853754830


##########
ci/docker/python-wheel-windows-vs2017.dockerfile:
##########
@@ -83,7 +83,7 @@ RUN choco install -r -y --no-progress python --version=%PYTHON_VERSION%
 RUN python -m pip install -U pip setuptools
 
 COPY python/requirements-wheel-build.txt arrow/python/
-RUN python -m pip install -r arrow/python/requirements-wheel-build.txt
+RUN python -m pip install tzdata -r arrow/python/requirements-wheel-build.txt

Review Comment:
   I think the tzdata should be installed in the env for testing the wheel, and shouldn't be required when _building_. 
   We do have a `python_wheel_windows_test.bat` script which I suppose is relevant here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org