[jira] Commented: (THRIFT-615) TThreadPoolServer doesn't call task_done after pulling tasks from it's clients queue

["David Reiss (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927698#action_12927698 ] 

David Reiss commented on THRIFT-615:
------------------------------------

No.  "except:" is really bad.  It should be "except Queue.Empty:"

> TThreadPoolServer doesn't call task_done after pulling tasks from it's clients queue
> ------------------------------------------------------------------------------------
>
>                 Key: THRIFT-615
>                 URL: https://issues.apache.org/jira/browse/THRIFT-615
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>            Reporter: Matt Jones
>            Assignee: David Reiss
>            Priority: Minor
>         Attachments: thrift-task-done-2.diff, thrift-task-done.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Exactly as the title says. The effect of the bug is that you can't join the clients queue, since no client has ever signalled itself as done. The fix is trivial (patch attached).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.