You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2023/01/09 14:40:19 UTC
[GitHub] [ignite] nizhikov opened a new pull request, #10473: IGNITE-17368 Remove obsolete GridClient JDBC driver
nizhikov opened a new pull request, #10473:
URL: https://github.com/apache/ignite/pull/10473
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov merged pull request #10473: IGNITE-17368 Remove obsolete GridClient JDBC driver
Posted by "nizhikov (via GitHub)" <gi...@apache.org>.
nizhikov merged PR #10473:
URL: https://github.com/apache/ignite/pull/10473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] petrov-mg commented on a diff in pull request #10473: IGNITE-17368 Remove obsolete GridClient JDBC driver
Posted by "petrov-mg (via GitHub)" <gi...@apache.org>.
petrov-mg commented on code in PR #10473:
URL: https://github.com/apache/ignite/pull/10473#discussion_r1106793161
##########
modules/core/src/main/java/org/apache/ignite/IgniteJdbcDriver.java:
##########
@@ -130,139 +123,9 @@
* <p> Defaults to {@code false}, meaning that the whole result set is fetched to memory eagerly.
* </li>
* </ul>
- *
Review Comment:
The javadoc above still mentions Java Client Based driver
`* JDBC driver can return two different types of connection: Ignite Java client based connection`
Let's remove it.
##########
modules/core/src/main/java/org/apache/ignite/IgniteJdbcDriver.java:
##########
@@ -436,27 +296,20 @@ public class IgniteJdbcDriver implements Driver {
if (!parseUrl(url, props))
throw new SQLException("URL is invalid: " + url);
- if (url.startsWith(URL_PREFIX)) {
- if (props.getProperty(PROP_CFG) != null)
- LOG.warning(PROP_CFG + " property is not applicable for this URL.");
-
- return new JdbcConnection(url, props);
- }
- else
- return new org.apache.ignite.internal.jdbc2.JdbcConnection(url, props);
+ return new org.apache.ignite.internal.jdbc2.JdbcConnection(url, props);
Review Comment:
Now we can get rid of the package name.
##########
modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcResultSetSelfTest.java:
##########
@@ -1128,4 +1131,65 @@ private TestObjectField(int a, String b) {
return S.toString(TestObjectField.class, this);
}
}
+
Review Comment:
Let's fix the codestyle here and below. At the very least, we should remove the mention of non-existent classes from the javadoc.
##########
modules/core/src/main/resources/META-INF/classnames.properties:
##########
@@ -403,8 +403,6 @@ org.apache.ignite.internal.events.DiscoveryCustomEvent
org.apache.ignite.internal.executor.GridExecutorService
org.apache.ignite.internal.executor.GridExecutorService$1
org.apache.ignite.internal.executor.GridExecutorService$TaskTerminateListener
-org.apache.ignite.internal.jdbc.JdbcConnectionValidationTask
-org.apache.ignite.internal.jdbc.JdbcConnectionValidationTask$1
Review Comment:
`org.apache.ignite.internal.processors.cache.query.jdbc.GridCacheQueryJdbcMetadataTask`
`org.apache.ignite.internal.processors.cache.query.jdbc.GridCacheQueryJdbcMetadataTask$JdbcDriverMetadataJob`
`org.apache.ignite.internal.processors.cache.query.jdbc.GridCacheQueryJdbcTask`
`org.apache.ignite.internal.processors.cache.query.jdbc.GridCacheQueryJdbcTask$JdbcDriverJob`
`org.apache.ignite.internal.processors.cache.query.jdbc.GridCacheQueryJdbcTask$JdbcDriverJob$1`
`org.apache.ignite.internal.processors.cache.query.jdbc.GridCacheQueryJdbcValidationTask`
Should be removed as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] petrov-mg commented on pull request #10473: IGNITE-17368 Remove obsolete GridClient JDBC driver
Posted by "petrov-mg (via GitHub)" <gi...@apache.org>.
petrov-mg commented on PR #10473:
URL: https://github.com/apache/ignite/pull/10473#issuecomment-1429666924
Please take a look at classes from the `org.apache.ignite.internal.processors.cache.query.jdbc` package.
GridCacheQueryJdbcMetadataTask
GridCacheQueryJdbcTask
GridCacheQueryJdbcValidationTask
It seems we should consider to remove them as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org