[GitHub] [calcite] zabetak commented on a change in pull request #1261: [CALCITE-3119] Deprecate Linq4j CorrelateJoinType (in favor of JoinType)

[GitBox <gi...@apache.org>]

zabetak commented on a change in pull request #1261: [CALCITE-3119] Deprecate Linq4j CorrelateJoinType (in favor of JoinType)
URL: https://github.com/apache/calcite/pull/1261#discussion_r292464435
 
 

 ##########
 File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
 ##########
 @@ -1154,11 +1154,30 @@ public void close() {
    * Returns elements of {@code outer} for which there is a member of
    * {@code inner} with a matching key. A specified
    * {@code EqualityComparer<TSource>} is used to compare keys.
+   *
+   * @deprecated Use {@link #correlateJoin(JoinType, Enumerable, Function1, Function2)}
    */
+  @Deprecated // to be removed before 2.0
   public static <TSource, TInner, TResult> Enumerable<TResult> correlateJoin(
-      final CorrelateJoinType joinType, final Enumerable<TSource> outer,
+      final CorrelateJoinType correlateJoinType, final Enumerable<TSource> outer,
       final Function1<TSource, Enumerable<TInner>> inner,
       final Function2<TSource, TInner, TResult> resultSelector) {
+    return correlateJoin(correlateJoinType.toJoinType(), outer, inner, resultSelector);
+  }
+
+  /**
+   * Returns elements of {@code outer} for which there is a member of
+   * {@code inner} with a matching key. A specified
+   * {@code EqualityComparer<TSource>} is used to compare keys.
 
 Review comment:
   I don't see the link with `EqualityComparer<TSource>`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services